agent icon indicating copy to clipboard operation
agent copied to clipboard

node_zfs_zpool_state should have suspended as a state

Open Hooloovoo opened this issue 3 years ago • 2 comments

Hello,

It is great that the node_exporter in Grafana agent now collects node_zfs_zpool_state. It currently has: unavail degraded faulted offline online removed

I have a pool that is in the "SUSPENDED" state: $ zpool status pool: [pool name] state: SUSPENDED status: One or more devices are faulted in response to IO failures. action: Make sure the affected devices are connected, then run 'zpool clear'. see: http://zfsonlinux.org/msg/ZFS-8000-HC

and so none of the above statuses are triggered (thankfully I also monitor for online != 1). Could you please add this status as well?

Hooloovoo avatar Jul 06 '22 09:07 Hooloovoo

Hey Aaron 👋

We're importing the upstream node_exporter code, where the ZFS pool states are defined here. The fastest way of handling this would be to open an issue or file a PR on the node_exporter repo and then update our dependency when the change is implemented.

There's no issue filed there, so I'm not sure if folks are aware of this status at all, would you mind creating one and linking it here so we can track its progress?

tpaschalis avatar Jul 06 '22 13:07 tpaschalis

Filed here: https://github.com/prometheus/node_exporter/issues/2421

Hooloovoo avatar Jul 11 '22 10:07 Hooloovoo

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity. Thank you for your contributions!

github-actions[bot] avatar Aug 20 '22 00:08 github-actions[bot]