Release candidates may cause new versioned docs to be created prematurely
From what I can tell of our publish_docs action and the docs-target action implementation, any commit to one of our release-* branches will cause versioned docs to be created.
If my understanding is correct, this means if we create a new release candidate in a release-* branch, we'll prematurely create versioned docs for it which will be set to the latest version.
It seems like the preferred behavior is that we only create new versioned docs after the initial tag is made, though maybe the behavior I described is fine as-is.
cc @jdbaldry @tpaschalis
If the behavior is going to be changed, a fix isn't pressing and just needs to be done by v0.26.0 (~4-6 weeks from now).
Shout-out to @jdbaldry, he's anticipated this and already has a solution for this problem.
The workflow used by Mimir only publishes the versioned docs if there is a matching release tag.
I was planning to bring this functionality over to the Agent as well for the next release, but wanted to improve our current way of publishing docs sooner rather than later.
In any case, good catch, and let's leave this Issue open for tracking the solution to this problem.
Thanks @tpaschalis, yeah hopefully this is suitable for your cases too :)
https://github.com/grafana/grafana-github-actions/blob/main/has-matching-release-tag/action.yaml has the best overview of the usage but it can be inferred from the workflow in Mimir too.
Let me know if you have any questions.
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity. Thank you for your contributions!
Reopening, as it's still not fixed. I'm going to assign myself so I don't lose track of it this time.