agent icon indicating copy to clipboard operation
agent copied to clipboard

Remove older Tanka libraries

Open rfratto opened this issue 2 years ago • 2 comments

The "v0" and v1 libs have been deprecated for a while, and I think the v2 configs landed on a good design.

Note that the smoke folder currently sits alongside the v0 libs, but is not deprecated and should not be removed.

We should remove all the deprecated stuff and replace it with:

production/tanka/grafana-agent/ 
  testbed/       # previously smoke/
  internal/      # previously v2/internal/
  main.libsonnet # previously v2/main.libsonnet 
  README.md      # previously v2/README.md 

cc @rlankfo for your opinion on me renaming smoke to testbed, since I'm not sure "smoke test" is really an accurate name for what that environment is.

Alternatively, production/tanka/grafana-agent/smoke can be moved to a higher folder, such as production/tanka/grafana-agent-testbed or production/tanka/grafana-agent-smoke.

rfratto avatar Mar 21 '22 22:03 rfratto

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity. Thank you for your contributions!

github-actions[bot] avatar Apr 21 '22 00:04 github-actions[bot]

cc @rlankfo for your opinion on me renaming smoke to testbed, since I'm not sure "smoke test" is really an accurate name for what that environment is.

+1 for renaming smoke to something like testbed, testkit, or testenv.

rlankfo avatar Apr 21 '22 19:04 rlankfo

This was done a few months ago. Closing as complete.

rfratto avatar Apr 09 '24 17:04 rfratto