graemedouglas
Need a way to remove printf()
On the nRF51822 platform I'm compiling for, having printf() in the code anywhere (even if it is never called) forces the compiler to include some library that also happens to include fclose(), which then conflicts with my implementation of the filesystem functions. Currently I've commented out
-
printQuery -
printTuple -
printRowSeparator -
printtoken
and set DB_CTCONF_SETTING_FEATURE_ERROR_MESSAGES to 0. It would be nice to have a #define that lets me remove all printf()s from compiling.
Did commenting out that code / disabling error messages remove all references to printf?
Hi @graemedouglas, could you assign this one to me, please?
I already have changes waiting for a push to fix this issue. However, the server doesn't allow me to do 'git push origin'. It looks like I don't have enough permissions to do it. Please, add me to the list of contributors of this project or create a branch '004-Need-a-way-to-remove-printf' to which I can push my changes.
Thanks, Andrii
@kupleva The best way to do this is through the pull request API. That is GitHub's intended usage pattern.
If you fork this repository and point your local repo's origin to your fork, and push their, you can initiate a pull request through GitHub's UI.
Thanks for the interest!
Hi @graemedouglas, did you have a chance to review my pull request #9 that aims to fix this issue?
Not yet, I'm sorry, I've been pretty busy of late. Start/end of contracts and publication deadlines coming up. I have done a code review and don't see anything objectionable to my eye, though. My apologies for the delay!
@graemedouglas, it's ok. i thought you'd avandoned this project. now i see it's not the case. of course this has lower priority than work/studies.
Fixed in pull request #9.
@graemedouglas,
many thanks for giving it a look!