Graeme Winter

Results 365 comments of Graeme Winter

> ```python > # FIXME find a more graceful way of handling this... > if len(valid_ranges) > 1: > sys.exit("Currently multiple blank regions unsupported") > ``` > > At the...

@biochem-fan please try again - I _think_ I have a fix in for > 1 non-blank region but would welcome verification

Anyone who looks at this please could you check the indexing around `experiments` in the list and `refl["id"]`

> Those with multiple blank ranges are mostly rubbish. > > ``` > 20 spots found on 38 images (max 3 / bin) > * * > * * >...

I think I need to check the workings & make sure that the experiment identifier assignment is being handled correctly: quite possibly something going quite wrong here.

Just created myself a slightly artificial example case with this script ``` from dials.array_family import flex data = flex.reflection_table.from_file("strong.refl") z = data["xyzobs.px.value"].parts()[2] data = data.select((z < 300) | (z >...

Also: ``` DIALS (2018) Acta Cryst. D74, 85-97. https://doi.org/10.1107/S2059798317017235 DIALS 3.dev.858-gea3a72878 The following parameters have been modified: input { experiments = symmetrized.expt reflections = symmetrized.refl } Checking for the existence...

Discussion with @phyy-nx -> - deprecate this kind of API - add explicit methods which _tell you_ the order - eventually one day retire the old and deprecated API However...

2D panel effective location would make a lot of sense… i.e. x, y coordinates of this panel in a bigger image (effectively invert the way that the I23 CBF files...