extra-java-module-info icon indicating copy to clipboard operation
extra-java-module-info copied to clipboard

Support addressing classified Jar via coordinates

Open jjohannes opened this issue 1 year ago • 2 comments

For example, to patch io.netty:netty-transport-native-epoll with classifier linux-x86_64 you have to use the file name:

module("netty-transport-native-epoll-4.1.87.Final-linux-x86_64.jar", "io.netty.transport.epoll.linux.x86_64")

It should be possible to do it like this:

module("io.netty:netty-transport-native-epoll|linux-x86_64", "io.netty.transport.epoll.linux.x86_64")

jjohannes avatar Jul 08 '24 15:07 jjohannes

Related: #129

jjohannes avatar Jul 08 '24 15:07 jjohannes

It should be possible to do it like this:

Don't forget a version for version-catalog accessor usage :-) Maybe a viable alternative: module("io.netty:netty-transport-native-epoll", "io.netty.transport.epoll.linux.x86_64") { classifier = "linux-x86_64" } or something like that.

Vampire avatar Jul 08 '24 15:07 Vampire

The feature is implemented with the notation proposed in the description. Follwoing the same "identifier" notation used in java-module-dependencies.

Generally, I would agree that we do to much "special" strings instead of a nicer DSL. For now, I want to stay consistent with things we already have in this and the other GradleX Modules Plugins.

Maybe something to revisit if we should do a 2.x with a reworked DSL.

jjohannes avatar Sep 21 '24 09:09 jjohannes