gradle icon indicating copy to clipboard operation
gradle copied to clipboard

Use guava cache instead of Map for CachingToolingImplementationLoader

Open reinsch82 opened this issue 9 months ago • 2 comments

The team city agent is very long running and therefore runs into OutOfMemory when we cache things for to long. The assumption is 15 different gradle versions, which is implied by the max cache size, seems to be enough for all use cases and if not there is just a small performance penalty. Same goes for the 7 days expiration time. expiration is handle on normal access methods not by some background event magic.

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

reinsch82 avatar May 10 '24 10:05 reinsch82

@bot-gradle test ACTR

reinsch82 avatar May 13 '24 09:05 reinsch82

I've triggered the following builds for you. Click here to see all build failures.

bot-gradle avatar May 13 '24 09:05 bot-gradle

@bot-gradle test ACTR

reinsch82 avatar May 13 '24 10:05 reinsch82

I've triggered the following builds for you. Click here to see all build failures.

bot-gradle avatar May 13 '24 10:05 bot-gradle