gradle-enterprise-build-validation-scripts icon indicating copy to clipboard operation
gradle-enterprise-build-validation-scripts copied to clipboard

Published 20 hours ago • verified publisher icon gradle

Predictive Test Selection is disabled when running builds

Open erichaagdev opened this issue 1 year ago • 1 comments

This PR adds the system property -Dpts.enabled=false to build invocations in order to disable PTS. The displayed invocation commands have also been updated to include the system property.

image

ℹ️ Note: The CI/Local experiments (exp5-gradle & exp4-maven) will also be invoked with -Dpts.enabled=false even if the original CI build did not have PTS disabled.

Closes #522

erichaagdev avatar Oct 20 '23 18:10 erichaagdev

@etiennestuder I want to make sure you see the note I have in the description:

The CI/Local experiments (exp5-gradle & exp4-maven) will also be invoked with -Dpts.enabled=false even if the original CI build did not have PTS disabled.

I think that is the desired state but it means we need to recommend users also disable PTS in the CI builds. Should we also update the wording then of the interactive mode to include this?

https://github.com/gradle/gradle-enterprise-build-validation-scripts/blob/5391c5888022de3dae3cf17dec18ce04d69671fc/components/scripts/gradle/05-validate-remote-build-caching-ci-local.sh#L276-L287

erichaagdev avatar Oct 20 '23 18:10 erichaagdev