develocity-build-config-samples icon indicating copy to clipboard operation
develocity-build-config-samples copied to clipboard

Replace `M1` tag in `capture-processor-arch` samples with more generic term

Open erichaagdev opened this issue 2 years ago • 3 comments

With M2 being made available, we should consider replacing the M1 tag in the capture-processor-arch samples with a more generic term (e.g. Apple Silicon).

See also: https://github.com/slackhq/kotlin-cli-util/blob/main/src/main/kotlin/slack/cli/AppleSiliconCompat.kt

erichaagdev avatar Feb 09 '23 15:02 erichaagdev

Just a thought: this is why we don't add these things to CCUD. :) Otherwise if we change this, it would break existing workflows. For example if a team were searching their dashboards for M1 they would suddenly not be able to find this if we changed the name. If we keep these in the samples, then teams can choose how to upgrade or change this.

runningcode avatar Mar 02 '23 10:03 runningcode

That is a good point. I am okay with closing this issue.

erichaagdev avatar Mar 02 '23 15:03 erichaagdev

I think we should update the sample for the very reason that it is a sample that can be manipulated by other developers when copy pasted. 👍 Also people don't tend to update "sample code".

runningcode avatar Mar 02 '23 16:03 runningcode