gradio icon indicating copy to clipboard operation
gradio copied to clipboard

Fix the text size and padding when the `Dropdown` box is empty with `multiselect=True`

Open abidlabs opened this issue 2 years ago • 14 comments

Created an issue so that we keep track of this @dawoodkhan82

Originally noted by @aliabid94: the text size and padding when the box is empty look a little off to me: Recording 2023-02-07 at 13 44 05

if you wanna just patch in this PR, or maybe tackle later

Originally posted by @aliabid94 in https://github.com/gradio-app/gradio/issues/3145#issuecomment-1421351216

abidlabs avatar Feb 09 '23 19:02 abidlabs

@abidlabs I'd love to take a shot if it's up for grabs :)

Neilblaze avatar Feb 14 '23 07:02 Neilblaze

Thanks @Neilblaze! @dawoodkhan82 have you already started working on this or is this up for grabs?

abidlabs avatar Feb 14 '23 15:02 abidlabs

It's up for grabs, I think this would be a great first issue. Thanks @Neilblaze

dawoodkhan82 avatar Feb 14 '23 15:02 dawoodkhan82

Thanks @dawoodkhan82! I was exploring the codebase and what I understood is that an update for padding & font-size in this is the task, right?

Do correct me if my approach is wrong. 😅

Also, I did try running the codebase on my local/codespaces, but I cannot figure out how to get this running (on any specific port). Could you please help me out with that?

OS : Windows 10 (64-bit) Browser : Chrome (latest)

Neilblaze avatar Feb 14 '23 22:02 Neilblaze

@Neilblaze It would actually be the updating the padding and font_size in the Multiselect.svelte file.

dawoodkhan82 avatar Feb 15 '23 21:02 dawoodkhan82

Thanks for the help! @dawoodkhan82 😄 I did try to run it locally, but I'm getting into this issue everytime I run bash scripts/build_frontend.sh in the root. I've followed all instructions very carefully & tried it on codespaces (after I failed to run it on my local), and even downgrading my default node (19.x.x) to node --version 16.x.x, but nothing is fixing the issue.

Neilblaze avatar Feb 16 '23 21:02 Neilblaze

Just to confirm, did you try setting this environmental variable?

@libai-lab Can you add the environment variable NODE_OPTIONS="--max-old-space-size=4096" like we do in our CI?

abidlabs avatar Feb 16 '23 21:02 abidlabs

@abidlabs yep, I've tried that. Nothing works as of now.

UPDATE : I'm taking one more shot at it starting from scratch. Let's see how it goes.

Neilblaze avatar Feb 16 '23 21:02 Neilblaze

@abidlabs I retried starting from scratch, and I'm getting the same issue again. Here's a snapshot of the err log when I run bash scripts/build_frontend.sh in the root.

P.S. → I did add the environment variable NODE_OPTIONS="--max-old-space-size=4096"

image

Neilblaze avatar Feb 16 '23 22:02 Neilblaze

And what is the npm and pnpm versions in this environment?

abidlabs avatar Feb 16 '23 22:02 abidlabs

And what is the npm and pnpm versions in this environment?

npm version is 9.4 and pnpm is 7

Neilblaze avatar Feb 16 '23 22:02 Neilblaze

I'm stumped, all that looks right to me. @pngwn would you have any other recommendations?

abidlabs avatar Feb 16 '23 22:02 abidlabs

@Neilblaze Could you run npx envinfo --system --binaries or pnpx envinfo --system --binaries and paste the output. Also post your full pnpm version: pnpm -v.

pngwn avatar Feb 16 '23 23:02 pngwn

@pngwn Apologies for the delay, here you go:

  • envinfo :
  System:
    OS: Linux 5.4 Ubuntu 20.04.5 LTS (Focal Fossa)
    CPU: (2) x64 Intel(R) Xeon(R) Platinum 8272CL CPU @ 2.60GHz
    Memory: 2.38 GB / 3.84 GB
    Container: Yes
    Shell: 5.0.17 - /bin/bash
  Binaries:
    Node: 19.6.0 - ~/nvm/current/bin/node
    Yarn: 1.22.19 - /usr/bin/yarn
    npm: 9.4.0 - ~/nvm/current/bin/npm
  • pnpm version : 7.27.1

P.S. :> I'm running on GitHub codespaces.

Neilblaze avatar Feb 19 '23 20:02 Neilblaze

Closed via #3211

abidlabs avatar Feb 23 '23 21:02 abidlabs