cocoapods-pod-merge icon indicating copy to clipboard operation
cocoapods-pod-merge copied to clipboard

Deployment Target needs to be merged to highest common target

Open KaiOelfke opened this issue 5 years ago • 4 comments

I experimented a bit with this plugin and when merging the pods BonMot and SnapKit the deployment target is set to 8.0 even though the pod BonMot only supports 9.0 and this results in SDK availability errors.

Example project: https://github.com/KaiOelfke/MergeTest

Either the MergeFile should specify a deployment target per group, take the deployment target from the Podfile or just automatically set it to the highest common target (in this case 9.0)

Also Podfile supports comments with # and strings with double quotes "" and MergeFile doesn't which would have saved me some time, if it would be mentioned in the documentation.

Otherwise it's a good idea. The launch time of the app I was experimenting with is improving quite a bit. Thanks for your work!

KaiOelfke avatar Nov 04 '19 09:11 KaiOelfke

The MergeFile already picks up sources and platforms from the Podfile, but I seem to have missed deployment targets, I’ll fix it. Thank you for reporting this!

I’ll mention about the comments in the README, that makes sense. The MergeFile parsing is pretty strict at the moment 😅

biocross avatar Nov 05 '19 03:11 biocross

Hi even i am facing this problem, can we get option to set deployment target or as mentioned in above thread can we done it through the pod file

gowtham1094 avatar Nov 13 '19 19:11 gowtham1094

Yep, I'm working on this. Will try to get a version out soon.

biocross avatar Nov 14 '19 03:11 biocross

Possibly related, but I can file a new issue if you request:

A Podfile with multiple Targets (watchOS, iOS, testing) that each define their platform will results in an error, though this is quite important to support. Thank you.

[!] Invalid `Podfile` file: The target `Pods` already has a platform set..

 #  from /Users/chris/Work/RWGPS/Code/RWGPS-iOS/MergeCache/Podfile:4
 #  -------------------------------------------
 #  platform :ios, '11.0'
 >  platform :watchos, '3.1'
 #  install! 'cocoapods', :integrate_targets => false, :lock_pod_sources => false
 #  -------------------------------------------

buddhisthead avatar Dec 13 '19 20:12 buddhisthead