simplelanguage icon indicating copy to clipboard operation
simplelanguage copied to clipboard

Improve make_component.sh

Open fniephaus opened this issue 5 years ago • 2 comments

This PR improves make_component.sh in the following ways:

  • "Exit immediately if a command exits with a non-zero status." (set -e)
  • Fix incorrect rm -rf COMPONENT_DIR and add user prompt before deleting directory
  • Suggest to run mvn package when simplelanguage.jar is not found
  • Use pushd/popd in favor of cd
  • Mark variables as readonly
  • Minor consistency fixes

fniephaus avatar Apr 01 '19 15:04 fniephaus

Could you please rebase? I merged a PR that made some changes to the script in question and re-enabled the part of the gate that checks the components.

boris-spas avatar Apr 02 '19 08:04 boris-spas

Done! PTAL

fniephaus avatar Apr 14 '19 16:04 fniephaus