native-build-tools icon indicating copy to clipboard operation
native-build-tools copied to clipboard
verified publisher icon graalvm

Disable CI startup on fork branches

Open linghengqian opened this issue 6 months ago • 3 comments

  • For https://github.com/graalvm/native-build-tools/issues/731 and https://github.com/graalvm/native-build-tools/issues/685 .
  • Disable CI startup on fork branches.
  • This is the source of the most annoying email reminders I encountered at https://github.com/graalvm/native-build-tools/issues/731. We have discussed something similar at https://github.com/oracle/graalvm-reachability-metadata/pull/229.
  • image

linghengqian avatar May 31 '25 19:05 linghengqian

This looks good to me. My only question is what should I do if I want to run workflow on my fork to verify some changes?

@melix @vjovanov @sdeleuze what do you think about this? Can this have any negative effects (for example on Spring or Micronaut).

dnestoro avatar Jun 02 '25 11:06 dnestoro

Both the current project and other projects I collaborate on use the Github Actions workflow_dispatch syntax in the CI configuration file, which means that a Job can be started directly from the github.com UI

Yes, you can trigger the workflow manually, but it won't pass the if statement you added in this PR, and therefore the job won't run, right?

The only way how you can run jobs on your fork is if you remove lines added in this PR, right?

dnestoro avatar Jun 02 '25 12:06 dnestoro

Yes, you can trigger the workflow manually, but it won't pass the if statement you added in this PR, and therefore the job won't run, right?

The only way how you can run jobs on your fork is if you remove lines added in this PR, right?

  • Yes, I misunderstood the role of workflow_dispatch. The related jobs will not be started.
  • image
  • To start the job, we can only manually remove the changes in the current PR in a new branch. Or, according to the general operation of the project in ASF, contributors will manually create a new CI file in the branch temporarily to test some large changes. Just like https://github.com/apache/shardingsphere/pull/21109#discussion_r978245395 described.

linghengqian avatar Jun 02 '25 12:06 linghengqian

I am closing this PR because it will prevent users to run workflow on their forks while in some cases they would like to test their PR before submitting it.

@linghengqian if you still feel this could be beneficial, you can reopen this PR.

dnestoro avatar Sep 23 '25 08:09 dnestoro