mx icon indicating copy to clipboard operation
mx copied to clipboard

JARDistribution force exclude dotfiles (.foo)

Open eregon opened this issue 2 weeks ago • 4 comments

https://github.com/graalvm/mx/blob/5a7e670c01c927dde427249427aedaee33388d29/src/mx/_impl/mx_jardistribution.py#L716-L718

This is problematic notably when using a JAR distribution to package Truffle internal resources, which may contain dotfiles for various reasons, due to e.g. including files from 3rd-party packages.

cc @tzezula @chumer

eregon avatar Dec 09 '25 19:12 eregon

I can easily work around in this case.

eregon avatar Dec 09 '25 19:12 eregon

This is easy enough to fix but should use mx_compat to preserve the old behavior for suites that are currently depending on it (if any).

dougxc avatar Dec 10 '25 08:12 dougxc

Good point. It might pull in new files. We should carefully check which files we are pulling in with this change. So yes I think mx_compat would be a good start to be on the safe side.

chumer avatar Dec 10 '25 12:12 chumer

Good point. It might pull in new files.

That's not a concern for Truffle languages resource jars because if currently they contain dot files the index will contain them but the jar won't and it will result in an error when extracting: https://graalvm.slack.com/archives/CNQSB2DHD/p1765305422419169?thread_ts=1765305407.559639&cid=CNQSB2DHD

eregon avatar Dec 12 '25 19:12 eregon