Build SVM with JDK 19.

Open oraluben opened this issue 3 years ago • 1 comments

Ref: oracle/graal#4623

Jun 06 '22 10:06 oraluben

Hi @dougxc , the current version of requiresConcealed seems to have issue. IIUC it's checking if the current jdk.javaCompliance is in the range of java_compliance, i.e.,

if java_compliance.__contains__(jdk.javaCompliance)

, i.e.,

if jdk.javaCompliance in java_compliance

. Instead mx now has (negation is not important here):

https://github.com/graalvm/mx/blob/c900245b403df797a8e9fa83597cfeb97482a0a7/mx_javamodules.py#L1121

I met this issue while having something like: https://github.com/oracle/graal/blob/e0f7b9735df345077373cdf82df499e923ca30d3/substratevm/mx.substratevm/suite.py#L229-L236

Does this fix look good to you: https://github.com/graalvm/mx/pull/263/commits/e4128a5bf56273c1bcf45fb8c58b0fc3844f0502

Jun 27 '22 06:06 oraluben