mx
mx copied to clipboard
Support overriding gcc/g++/ar from environment
Most build system support this, and on some environment, raw "gcc" "g++" and "ar" might not be available
Hello Marc-Antoine Perennou, thanks for contributing a PR to our project!
We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address marc-antoine -(at)- perennou -(dot)- com. You can sign it at that link.
If you think you've already signed it, please comment below and we'll check.
OCA sent
Hello Marc-Antoine Perennou, thanks for contributing a PR to our project!
We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address Marc-Antoine -(at)- Perennou -(dot)- com. You can sign it at that link.
If you think you've already signed it, please comment below and we'll check.
Is there really no way to do this online? It's really boring having to wait to get my hands on a printer/scanner just to resubmit because it was rejected the first time.
The OCA signing process is not under the control of the GraalVM teams. I suspect (hope!) it will improve when OpenJDK moves to GitHub.
Hello Marc-Antoine Perennou, thanks for contributing a PR to our project!
We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address Marc-Antoine -(at)- Perennou -(dot)- com. You can sign it at that link.
If you think you've already signed it, please comment below and we'll check.
Done
Marc-Antoine Perennou has signed the Oracle Contributor Agreement (based on email address Marc-Antoine -(at)- Perennou -(dot)- com) so can contribute to this repository.
Do we still need this? I think the toolchains are now defined in ninja-toolchain/*.ninja
, instead of hardcoded.
Looks like this code changed exactly in the time between signing the OCA and it getting processed by our bot. In particular this https://github.com/graalvm/mx/commit/403e97800ef898ccdf04b75a8783c5a123048fc4 looks related. @gilles-duboscq Is this doing the same thing? Or is this an orthogonal change?