mx icon indicating copy to clipboard operation
mx copied to clipboard

Support overriding gcc/g++/ar from environment

Open Keruspe opened this issue 5 years ago • 9 comments

Most build system support this, and on some environment, raw "gcc" "g++" and "ar" might not be available

Keruspe avatar Apr 08 '19 12:04 Keruspe

Hello Marc-Antoine Perennou, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address marc-antoine -(at)- perennou -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

graalvmbot avatar Apr 08 '19 12:04 graalvmbot

OCA sent

Keruspe avatar Apr 08 '19 12:04 Keruspe

Hello Marc-Antoine Perennou, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address Marc-Antoine -(at)- Perennou -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

graalvmbot avatar Jan 09 '20 20:01 graalvmbot

Is there really no way to do this online? It's really boring having to wait to get my hands on a printer/scanner just to resubmit because it was rejected the first time.

Keruspe avatar Jan 13 '20 13:01 Keruspe

The OCA signing process is not under the control of the GraalVM teams. I suspect (hope!) it will improve when OpenJDK moves to GitHub.

dougxc avatar Jan 13 '20 14:01 dougxc

Hello Marc-Antoine Perennou, thanks for contributing a PR to our project!

We use the Oracle Contributor Agreement to make the copyright of contributions clear. We don't have a record of you having signed this yet, based on your email address Marc-Antoine -(at)- Perennou -(dot)- com. You can sign it at that link.

If you think you've already signed it, please comment below and we'll check.

graalvmbot avatar Nov 15 '21 14:11 graalvmbot

Done

Keruspe avatar Nov 16 '21 09:11 Keruspe

Marc-Antoine Perennou has signed the Oracle Contributor Agreement (based on email address Marc-Antoine -(at)- Perennou -(dot)- com) so can contribute to this repository.

graalvmbot avatar Nov 29 '21 12:11 graalvmbot

Do we still need this? I think the toolchains are now defined in ninja-toolchain/*.ninja, instead of hardcoded.

Looks like this code changed exactly in the time between signing the OCA and it getting processed by our bot. In particular this https://github.com/graalvm/mx/commit/403e97800ef898ccdf04b75a8783c5a123048fc4 looks related. @gilles-duboscq Is this doing the same thing? Or is this an orthogonal change?

rschatz avatar Jan 17 '22 14:01 rschatz