mandrel icon indicating copy to clipboard operation
mandrel copied to clipboard

CI: Enable arm64 runners

Open zakkak opened this issue 9 months ago • 7 comments

  • Changes the way we pass repositories and versions/tags/branches so that we can use a single input for each pair, e.g. graalvm/mandrel:graal/master which is <repo>:<version>
  • Adds new os input to allow us to chose ubuntu-24.04-arm and macos at some point in the future.
  • Introduces a new weekly build on AArch64

Closes #823

zakkak avatar Mar 17 '25 17:03 zakkak

Note: CI runs are expected to fail due to https://github.com/oracle/graal/pull/10858 not being merged yet.

zakkak avatar Mar 17 '25 17:03 zakkak

Is there a GHA run with this?

Only for AArch64 https://github.com/zakkak/mandrel/actions/runs/13905609233 with a build of https://github.com/oracle/graal/pull/10858 which fails due to https://github.com/oracle/graal/pull/10856 not being present in https://github.com/oracle/graal/pull/10858

Once graal master gets in shape I plan to do a more complete run.

zakkak avatar Mar 17 '25 18:03 zakkak

Scheduled a nightly and a weekly build on my repo for testing:

  • https://github.com/zakkak/mandrel/actions/runs/14080588191
  • https://github.com/zakkak/mandrel/actions/runs/14080588301

zakkak avatar Mar 26 '25 08:03 zakkak

The pipelines look good as in "they run as expected". It seems we have some things to fix in the tests on AArch64, which I suggest doing separately.

@jerboaa WDYT? Merging this is going to create some (weekly) noise in https://github.com/graalvm/mandrel/issues/830.

zakkak avatar Mar 27 '25 10:03 zakkak

The pipelines look good as in "they run as expected". It seems we have some things to fix in the tests on AArch64, which I suggest doing separately.

@jerboaa WDYT? Merging this is going to create some (weekly) noise in #830.

Most of the tests fail because of no Aarch64 image available needed for the tests. Most notably mssql, db2, oracle and ryuk containers.

Perhaps there is no point in including them when there are no images available to test? Should we get inclusions/exclusions for them added for Aarch64 before we merge?

jerboaa avatar Mar 27 '25 11:03 jerboaa

Should we get inclusions/exclusions for them added for Aarch64 before we merge?

I was thinking what would be the best way to achieve this and I lean towards adding an extra field in https://github.com/quarkusio/quarkus/blob/main/.github/native-tests.json to indicate the "supported" architectures as this is expected to be useful if/when Quarkus enables AArch64 testing as well. I will start a discussion on the Quarkus repository.

Update: Discussion link https://github.com/quarkusio/quarkus/discussions/47084

zakkak avatar Mar 31 '25 14:03 zakkak

Yes, this really is a quarkus test compatibility issue which would be visible in quarkus too. Best fixed there (in terms of test exclusions).

jerboaa avatar Mar 31 '25 15:03 jerboaa

This PR appears to be stale because it has been open 30 days with no activity. This PR will be closed in 7 days unless Stale label is removed, a new comment is made, or not-Stale label is added.

github-actions[bot] avatar May 01 '25 00:05 github-actions[bot]