Ruturaj Mohite comments

Results 46 comments of


                                            Ruturaj Mohite

download_cached_file should retry if there is a http error code

How about handling the RetryError by attempting to download once more(in the except statement) so that HTTPError can be raised with the latest status code

download_cached_file should retry if there is a http error code

Please review the PR and suggest changes

Unused and double imports

This issue is still unsolved, so I am working on it

UnicodeDecodeError details not logged

Hey, may I know what exactly is required in the warning

Setting.py: Change property name

@Blackcipher101 This issue already has 4 PRs on it. Review them instead of sending your own

Bear.py: Add retry feature

@abhishalya Can you please review this PR

[mesheryctl] cli doesn't handle incorrect commands correctly

> @leecalcote can you please assign me this issue. I researched on this a bit and found some possible ways to show the error. Broadly there are two ways to...

[Server] Kubernetes: Cannot delete the last cluster

> @Revolyssup, I researched a little bit on this issue. My initial thought is that there could be two ways to tackle this. > > - Since our Kubernetes middleware...

[Server] Use same Golang logger and log format

> Almost forgot to mention, should these lines be deleted? The nearest error's already handled in the previous lines. https://github.com/meshery/meshery/blob/0dbac4aa74e17ef342d29facbbe5e090d7791aa0/cmd/main.go#L147_L149 Yep seems redundant

[Server] Use same Golang logger and log format

Oh by the way @haanhvu. What about [these](https://github.com/meshery/meshery/pull/5603/files#diff-c444f711e9191b53952edb65bfd8c644419fc7695c62611dc0fb304b4fb197d6L50). Can we replace these with meshkit too?