Gregor Martynus

After selecting "JSON Web Token" is still had to configure the "Edit Tag" prompt

3

Following the README instructions, it didn’t yet work for me after the step > Use auto-complete to select the `JSON Web Token` tag: It showed the `[JSON WEB TOKEN]` with...

The `endpoint()` method currently returns `body` as the key holding the request body. We should rename it to `data` to align with `data` parameter in `@octokit/request`: https://github.com/octokit/request.js/#the-data-parameter--set-request-body-directly We can start...

We only support it for legacy reasons. GitHub is no longer documenting the REST API endpoints using the `:name` notation for a long time now. We should remove support for...

Today, TypeScript does not complain about this ```ts endpoint("GET /orgs/:org"); ``` But it should, because the `org` parameter is required. If `"GET /orgs/:org"` is set, then TypeScript should complain that...

Response schemas: set all keys as required, add `additionalProperties = false` flag

5

We assume that the response schemas are complete. There will be no additional keys, and all keys are guaranteed to be set. The current definitions for response schemas don't set...

https://github.com/octokit/routes/blob/f2235e10d84627935b304ee919b1da61c8103c20/lib/endpoint/find-routes.js#L12 Since #667, `routeBlocks.length` will always be 1 🎉 The source code can now be simplified quite a bit, there is always just one route, no need to iterate through...

Flag routes with paginated responses that have a result namespace

1

Ref https://github.com/octokit/rest.js/issues/1161 ### Affected routes - [ ] https://developer.github.com/v3/search/#example (key `items`) - [ ] https://developer.github.com/v3/checks/runs/#list-check-runs-for-a-specific-ref (key: `check_runs`) - [ ] https://developer.github.com/v3/checks/runs/#list-check-runs-in-a-check-suite (key: `check_runs`) - [ ] https://developer.github.com/v3/checks/suites/#list-check-suites-for-a-specific-ref (key: `check_suites`) -...

OpenAPI: absolute URL for "Upload a release asset" endpoint

3

The route for [Upload a release asset](https://developer.github.com/v3/repos/releases/#upload-a-release-asset) is `POST :upload_url`. The OpenAPI spec works around a base URL -> relative paths -> http method, it throws an error for `{upload_url}`...

Follow up to https://github.com/octokit/rest.js/issues/1684#issuecomment-617998848 Example, but there are many - endpoint scope: Repos - endpoint name: List public repositories - route: `GET /repositories` - documentation URL: https://developer.github.com/v3/repos/#list-public-repositories We can look...

Add required app permissions to routes

2

We can scrape this page: https://developer.github.com/v3/apps/permissions/ and it's GitHub Enterprise (Server) counterparts