gqty icon indicating copy to clipboard operation
gqty copied to clipboard

Published 20 hours ago • verified publisher icon gqty-dev

Update react monorepo to v18 (major)

Open renovate[bot] opened this issue 3 years ago • 12 comments

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react (source) >=16.14.0 -> >=18.2.0 age adoption passing confidence
react (source) ^17.0.2 -> ^18.2.0 age adoption passing confidence
react-dom (source) ^17.0.2 -> ^18.2.0 age adoption passing confidence
react-test-renderer (source) ^17.0.2 -> ^18.2.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

renovate[bot] avatar Mar 29 '22 17:03 renovate[bot]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gqty/gqty/HTkmm4GAYtAbzuBHKC5sU388g8xL
✅ Preview: Failed

[Deployment for ca0456a failed]

vercel[bot] avatar Mar 29 '22 17:03 vercel[bot]

Partially fixed the failing tests, no idea how the remaining await waitForNextUpdate(); should work in React 18.

vicary avatar Mar 31 '22 11:03 vicary

@PabloSzx you may want to take a look at this.

vicary avatar Apr 01 '22 18:04 vicary

Libraries pending for React 18:

  1. [x] @chakra-ui/react
  2. [x] react-use
  3. [ ] @guild-docs/client
  4. [x] @theguild/components
  5. [x] @testing-library/react
  6. [ ] @testing-library/react-hooks

Dependencies to be combined with this PR:

  1. @theguild/components@^2
  2. @chakra-ui/react@^2
  3. framer-motion@^7

vicary avatar Apr 10 '22 06:04 vicary

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gqty ❌ Failed (Inspect) Sep 3, 2022 at 6:57AM (UTC)

vercel[bot] avatar Apr 19 '22 03:04 vercel[bot]

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: pnpm-lock.yaml
installing v2 tool pnpm v7.3.0
npm WARN config global `--global`, `--local` are deprecated. Use `--location=global` instead.

added 1 package in 3s
linking tool pnpm v7.3.0
7.3.0
Scope: all 14 workspace projects
Progress: resolved 1, reused 0, downloaded 0, added 0
Progress: resolved 9, reused 0, downloaded 0, added 0
Progress: resolved 22, reused 0, downloaded 9, added 0
Progress: resolved 32, reused 0, downloaded 23, added 0
Progress: resolved 37, reused 0, downloaded 29, added 0
Progress: resolved 44, reused 0, downloaded 35, added 0
Progress: resolved 53, reused 0, downloaded 45, added 0
Progress: resolved 61, reused 0, downloaded 52, added 0
Progress: resolved 67, reused 0, downloaded 54, added 0
Progress: resolved 71, reused 0, downloaded 61, added 0
Progress: resolved 85, reused 0, downloaded 74, added 0
Progress: resolved 97, reused 0, downloaded 87, added 0
examples/vite-example                    |  WARN  deprecated @vitejs/[email protected]
Progress: resolved 106, reused 0, downloaded 97, added 0
Progress: resolved 112, reused 0, downloaded 105, added 0
Progress: resolved 117, reused 0, downloaded 109, added 0
Progress: resolved 119, reused 0, downloaded 114, added 0
Progress: resolved 119, reused 0, downloaded 115, added 0
Progress: resolved 120, reused 0, downloaded 115, added 0
Progress: resolved 121, reused 0, downloaded 118, added 0
Progress: resolved 122, reused 0, downloaded 118, added 0
Progress: resolved 122, reused 0, downloaded 119, added 0
Progress: resolved 122, reused 0, downloaded 122, added 0
Progress: resolved 124, reused 0, downloaded 122, added 0
Progress: resolved 125, reused 0, downloaded 122, added 0
Progress: resolved 125, reused 0, downloaded 123, added 0
Progress: resolved 125, reused 0, downloaded 124, added 0
Progress: resolved 125, reused 0, downloaded 125, added 0
Progress: resolved 126, reused 0, downloaded 125, added 0
Progress: resolved 126, reused 0, downloaded 126, added 0
Progress: resolved 127, reused 0, downloaded 126, added 0
Progress: resolved 128, reused 0, downloaded 127, added 0
Progress: resolved 162, reused 0, downloaded 136, added 0
Progress: resolved 190, reused 0, downloaded 166, added 0
Progress: resolved 203, reused 0, downloaded 179, added 0
Progress: resolved 221, reused 0, downloaded 198, added 0
Progress: resolved 241, reused 0, downloaded 212, added 0
Progress: resolved 258, reused 0, downloaded 235, added 0
Progress: resolved 281, reused 0, downloaded 254, added 0
Progress: resolved 295, reused 0, downloaded 271, added 0
Progress: resolved 307, reused 0, downloaded 284, added 0
Progress: resolved 317, reused 0, downloaded 290, added 0
Progress: resolved 327, reused 0, downloaded 301, added 0
Progress: resolved 336, reused 0, downloaded 310, added 0
Progress: resolved 346, reused 0, downloaded 322, added 0
Progress: resolved 356, reused 0, downloaded 334, added 0
Progress: resolved 368, reused 0, downloaded 343, added 0
Progress: resolved 377, reused 0, downloaded 352, added 0
Progress: resolved 387, reused 0, downloaded 362, added 0
Progress: resolved 395, reused 0, downloaded 370, added 0
Progress: resolved 407, reused 0, downloaded 382, added 0
Progress: resolved 412, reused 0, downloaded 388, added 0
Progress: resolved 434, reused 0, downloaded 407, added 0
Progress: resolved 468, reused 0, downloaded 443, added 0
Progress: resolved 501, reused 0, downloaded 476, added 0
Progress: resolved 531, reused 0, downloaded 507, added 0
Progress: resolved 553, reused 0, downloaded 525, added 0
Progress: resolved 600, reused 0, downloaded 577, added 0
Progress: resolved 640, reused 0, downloaded 612, added 0
Progress: resolved 679, reused 0, downloaded 651, added 0
Progress: resolved 717, reused 0, downloaded 693, added 0
Progress: resolved 759, reused 0, downloaded 730, added 0
Progress: resolved 796, reused 0, downloaded 768, added 0
Progress: resolved 839, reused 0, downloaded 805, added 0
Progress: resolved 862, reused 0, downloaded 815, added 0
Progress: resolved 895, reused 0, downloaded 850, added 0
Progress: resolved 932, reused 0, downloaded 890, added 0
Progress: resolved 956, reused 0, downloaded 910, added 0
Progress: resolved 984, reused 0, downloaded 940, added 0
Progress: resolved 1010, reused 0, downloaded 968, added 0
Progress: resolved 1031, reused 0, downloaded 989, added 0
Progress: resolved 1050, reused 0, downloaded 1007, added 0
Progress: resolved 1061, reused 0, downloaded 1019, added 0
internal/website                         |  WARN  deprecated @braintree/[email protected]
Progress: resolved 1068, reused 0, downloaded 1032, added 0
Progress: resolved 1088, reused 0, downloaded 1045, added 0
packages/react                           |  WARN  deprecated [email protected]
Progress: resolved 1107, reused 0, downloaded 1064, added 0
Progress: resolved 1136, reused 0, downloaded 1091, added 0
Progress: resolved 1172, reused 0, downloaded 1130, added 0
Progress: resolved 1206, reused 0, downloaded 1166, added 0
Progress: resolved 1231, reused 0, downloaded 1189, added 0
Progress: resolved 1278, reused 0, downloaded 1234, added 0
Progress: resolved 1319, reused 0, downloaded 1274, added 0
Progress: resolved 1352, reused 0, downloaded 1311, added 0
Progress: resolved 1383, reused 0, downloaded 1341, added 0
Progress: resolved 1416, reused 0, downloaded 1375, added 0
Progress: resolved 1436, reused 0, downloaded 1390, added 0
Progress: resolved 1479, reused 0, downloaded 1433, added 0
Progress: resolved 1496, reused 0, downloaded 1453, added 0
Progress: resolved 1530, reused 0, downloaded 1485, added 0
Progress: resolved 1567, reused 0, downloaded 1531, added 0
Progress: resolved 1596, reused 0, downloaded 1558, added 0
Progress: resolved 1603, reused 0, downloaded 1570, added 0
Progress: resolved 1603, reused 0, downloaded 1571, added 0
Progress: resolved 1605, reused 0, downloaded 1571, added 0
Progress: resolved 1629, reused 0, downloaded 1596, added 0
Progress: resolved 1659, reused 0, downloaded 1613, added 0
internal/website                         |  WARN  deprecated [email protected]
internal/website                         |  WARN  deprecated [email protected]
internal/website                         |  WARN  deprecated [email protected]
internal/website                         |  WARN  deprecated [email protected]
Progress: resolved 1701, reused 0, downloaded 1657, added 0
Progress: resolved 1714, reused 0, downloaded 1681, added 0
Progress: resolved 1715, reused 0, downloaded 1681, added 0
Progress: resolved 1715, reused 0, downloaded 1683, added 0
Progress: resolved 1716, reused 0, downloaded 1683, added 0
Progress: resolved 1736, reused 0, downloaded 1696, added 0
Progress: resolved 1757, reused 0, downloaded 1723, added 0
Progress: resolved 1757, reused 0, downloaded 1725, added 0, done
 ERR_PNPM_PEER_DEP_ISSUES  Unmet peer dependencies

examples/react
└─┬ @chakra-ui/react
  ├─┬ @chakra-ui/modal
  │ ├─┬ @chakra-ui/focus-lock
  │ │ └─┬ react-focus-lock
  │ │   └── ✕ unmet peer react@"^16.8.0 || ^17.0.0": found 18.2.0
  │ └─┬ react-remove-scroll
  │   └── ✕ unmet peer react@"^16.8.0 || ^17.0.0": found 18.2.0
  └─┬ @chakra-ui/toast
    └─┬ @reach/alert
      ├── ✕ unmet peer react@"^16.8.0 || 17.x": found 18.2.0
      ├── ✕ unmet peer react-dom@"^16.8.0 || 17.x": found 18.2.0
      ├─┬ @reach/utils
      │ ├── ✕ unmet peer react@"^16.8.0 || 17.x": found 18.2.0
      │ └── ✕ unmet peer react-dom@"^16.8.0 || 17.x": found 18.2.0
      └─┬ @reach/visually-hidden
        ├── ✕ unmet peer react@"^16.8.0 || 17.x": found 18.2.0
        └── ✕ unmet peer react-dom@"^16.8.0 || 17.x": found 18.2.0

internal/website
├─┬ @chakra-ui/react
│ ├─┬ @chakra-ui/modal
│ │ ├─┬ @chakra-ui/focus-lock
│ │ │ └─┬ react-focus-lock
│ │ │   └── ✕ unmet peer react@"^16.8.0 || ^17.0.0": found 18.2.0
│ │ └─┬ react-remove-scroll
│ │   └── ✕ unmet peer react@"^16.8.0 || ^17.0.0": found 18.2.0
│ └─┬ @chakra-ui/toast
│   └─┬ @reach/alert
│     ├── ✕ unmet peer react@"^16.8.0 || 17.x": found 18.2.0
│     ├── ✕ unmet peer react-dom@"^16.8.0 || 17.x": found 18.2.0
│     ├─┬ @reach/utils
│     │ ├── ✕ unmet peer react@"^16.8.0 || 17.x": found 18.2.0
│     │ └── ✕ unmet peer react-dom@"^16.8.0 || 17.x": found 18.2.0
│     └─┬ @reach/visually-hidden
│       ├── ✕ unmet peer react@"^16.8.0 || 17.x": found 18.2.0
│       └── ✕ unmet peer react-dom@"^16.8.0 || 17.x": found 18.2.0
├─┬ @guild-docs/client
│ ├─┬ mdx-mermaid
│ │ └── ✕ unmet peer react@"^16.8.4 || ^17.0.0": found 18.2.0
│ ├─┬ react-children-utilities
│ │ └── ✕ unmet peer react@"17.x.x || 16.x.x || 15.x.x": found 18.2.0
│ └─┬ use-immer
│   └── ✕ unmet peer react@"^16.8.0 || ^17.0.1": found 18.2.0
└─┬ @theguild/components
  ├── ✕ unmet peer react@^17.0.2: found 18.2.0
  ├── ✕ unmet peer react-dom@^17.0.2: found 18.2.0
  ├─┬ @radix-ui/react-navigation-menu
  │ ├── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ ├── ✕ unmet peer react-dom@"^16.8 || ^17.0": found 18.2.0
  │ ├─┬ @radix-ui/react-collection
  │ │ ├── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ │ ├─┬ @radix-ui/react-compose-refs
  │ │ │ └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ │ ├─┬ @radix-ui/react-context
  │ │ │ └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ │ └─┬ @radix-ui/react-primitive
  │ │   ├── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ │   └─┬ @radix-ui/react-slot
  │ │     └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ ├─┬ @radix-ui/react-dismissable-layer
  │ │ ├── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ │ ├─┬ @radix-ui/react-use-body-pointer-events
  │ │ │ ├── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ │ │ └─┬ @radix-ui/react-use-layout-effect
  │ │ │   └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ │ ├─┬ @radix-ui/react-use-callback-ref
  │ │ │ └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ │ └─┬ @radix-ui/react-use-escape-keydown
  │ │   └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ ├─┬ @radix-ui/react-id
  │ │ └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ ├─┬ @radix-ui/react-use-controllable-state
  │ │ └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ ├─┬ @radix-ui/react-use-direction
  │ │ └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ ├─┬ @radix-ui/react-use-previous
  │ │ └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  │ └─┬ @radix-ui/react-visually-hidden
  │   └── ✕ unmet peer react@"^16.8 || ^17.0": found 18.2.0
  ├─┬ react-instantsearch-dom
  │ ├── ✕ unmet peer react@">= 16.3.0 < 18": found 18.2.0
  │ └── ✕ unmet peer react-dom@">= 16.3.0 < 18": found 18.2.0
  └─┬ react-paginate
    └── ✕ unmet peer react@"^16 || ^17": found 18.2.0

packages/react
├─┬ @testing-library/react
│ ├── ✕ unmet peer react@<18.0.0: found 18.2.0
│ └── ✕ unmet peer react-dom@<18.0.0: found 18.2.0
└─┬ @testing-library/react-hooks
  ├── ✕ unmet peer react@"^16.9.0 || ^17.0.0": found 18.2.0
  ├── ✕ unmet peer react-dom@"^16.9.0 || ^17.0.0": found 18.2.0
  └── ✕ unmet peer react-test-renderer@"^16.9.0 || ^17.0.0": found 18.2.0

hint: If you don't want pnpm to fail on peer dependency issues, add "strict-peer-dependencies=false" to an .npmrc file at the root of your project.

renovate[bot] avatar May 19 '22 22:05 renovate[bot]

@PabloSzx You may have to replace @guild-doc/client in internal/website with their new boilerplate, more info here https://github.com/the-guild-org/the-guild-docs/issues/580#issuecomment-1203744419.

vicary avatar Aug 03 '22 10:08 vicary

Partially fixed the failing tests, no idea how the remaining await waitForNextUpdate(); should work in React 18.

@vicary Do you recall what the errors were? I recently hit a few test errors after upgrading an application to React 18 and might be able to help out. It looks like the test run logs have expired.

nickpassarella avatar Nov 20 '22 15:11 nickpassarella

@nickpassarella AFAIK this is mainly caused a deprecated dep of the guild docs, we should use their new package for the website.

But React 18 may introduce another bug mentioned in Discord, where subscriptions do not properly cancel due to concurrency mode.

Feel free to take a look if there is anything else causing the red.

vicary avatar Nov 20 '22 18:11 vicary

For me in React 18 useTransactionQuery doesn't return fetched data. It does request, and I can see the query logged via Gqty Logger, but data is always undefined and isLoading is always true.

The problem goes away if I switch to React 17.

vasyas avatar Nov 22 '22 10:11 vasyas

@vasyas Thanks for reporting, it would be really kind of you to create an issue so I don't get lost when I am busy crunching through the list.

vicary avatar Nov 22 '22 11:11 vicary

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

renovate[bot] avatar Nov 28 '22 13:11 renovate[bot]