cts icon indicating copy to clipboard operation
cts copied to clipboard

workgroupUniformLoad: test pointer-to-atomic variant

Open dneto0 opened this issue 9 months ago • 7 comments

See https://github.com/gpuweb/gpuweb/pull/5141

This requires basic testing:

  • that all invocations get the same value from the atomic
  • that it passes uniformity checks (the load is treated as uniform)

Ideally we would also modify the memory model tests to stress test the case. (That would likely be on me, as I'm the maintainer of those tests)

dneto0 avatar Apr 10 '25 16:04 dneto0

I think this is done in https://github.com/gpuweb/cts/commit/d3ac5784fb25afe1a9605af57112b854bb8206c7 already?

dj2 avatar Apr 10 '25 16:04 dj2

https://github.com/gpuweb/cts/pull/4332
oh, I didn't now about that!

It's a good start.

  • I'd also like to see loading from an atomic inside a larger workgroup variable. The #4332 only tests the case where the atomic is the whole store type to the variable.
  • extend uniformity tests (my second point above).

dneto0 avatar Apr 10 '25 16:04 dneto0

@beaufortfrancois FYI in case you wanted to pursue this further

dneto0 avatar Apr 10 '25 17:04 dneto0

@dneto0 I'll let you handle it if that's okay. If not, I can start working on it.

beaufortfrancois avatar Apr 10 '25 18:04 beaufortfrancois

@dneto0 I've started https://github.com/gpuweb/cts/pull/4347 and https://github.com/gpuweb/cts/pull/4348

beaufortfrancois avatar Apr 11 '25 08:04 beaufortfrancois

Let me know if we can close this issue or if we shall wait for @dneto0 to modify the memory model tests as well.

beaufortfrancois avatar Apr 14 '25 17:04 beaufortfrancois

Please keep this open for the memory model stress tests. Otherwise I'd open a new one for the stress tests... :-)

dneto0 avatar Apr 24 '25 13:04 dneto0