cts icon indicating copy to clipboard operation
cts copied to clipboard

Fix reifyTextureViewDescriptor

Open kainino0x opened this issue 1 year ago • 1 comments

I updated it incorrectly in the types roll. Not sure why, I just didn't think about it. (Nothing actually triggers this right now because none of the tests are setting usage on the view descriptor, so it doesn't affect any existing tests.)

Issue: #3953


Requirements for PR author:

  • [x] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [x] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [x] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • [x] Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [ ] Tests are properly located in the test tree.
  • [ ] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • [ ] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • [ ] Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

kainino0x avatar Sep 25 '24 21:09 kainino0x

@vonture PTAL (no rush)

kainino0x avatar Sep 27 '24 23:09 kainino0x

Thanks Kai!

vonture avatar Sep 30 '24 12:09 vonture