cts icon indicating copy to clipboard operation
cts copied to clipboard

Handle async pipeline creation errors more gracefully

Open toji opened this issue 2 years ago • 6 comments
trafficstars

These tests used to be producing validation errors which could be caught by the normal test harness, but after my changes in #3125 they're rejecting and throwing uncaught exceptions instead. This adds some try-catches around them and does an explicit t.fail() if a GPUPipelineError is thrown.

Not landing just yet, because I haven't been able to repro original issue yet so this is just speculative. Should be easier to test early next week according to conversation in the linked issue.

Issue: #3157


Requirements for PR author:

  • [x] All missing test coverage is tracked with "TODO" or .unimplemented().
  • [x] New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • [ ] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • [ ] Tests are properly located in the test tree.
  • [ ] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
  • [ ] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • [ ] Helpers and types promote readability and maintainability.

When landing this PR, be sure to make any necessary issue status updates.

toji avatar Nov 10 '23 23:11 toji

Hey @toji - is this PR ready for review? It's marked draft, but has 3 reviewers assigned. Thanks!

ben-clayton avatar Dec 04 '23 20:12 ben-clayton

@ben-clayton I'm seeing no reviews requested, just 3 suggestions made by GitHub.

kainino0x avatar Dec 04 '23 22:12 kainino0x

Right you are. Completely unable to parse the GitHub UI

ben-clayton avatar Dec 04 '23 22:12 ben-clayton

I think it's worthwhile to land this. Kai, could you PTAL?

toji avatar Dec 12 '23 22:12 toji

Any progress on this?

sagudev avatar Jun 23 '24 09:06 sagudev

FYI @toji: https://github.com/gpuweb/cts/pull/3844

kainino0x avatar Jul 15 '24 17:07 kainino0x