cts
cts copied to clipboard
Handle async pipeline creation errors more gracefully
These tests used to be producing validation errors which could be caught by the normal test harness, but after my changes in #3125 they're rejecting and throwing uncaught exceptions instead. This adds some try-catches around them and does an explicit t.fail() if a GPUPipelineError is thrown.
Not landing just yet, because I haven't been able to repro original issue yet so this is just speculative. Should be easier to test early next week according to conversation in the linked issue.
Issue: #3157
Requirements for PR author:
- [x] All missing test coverage is tracked with "TODO" or
.unimplemented(). - [x] New helpers are
/** documented */and new helper files are found inhelper_index.txt. - [ ] Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
Requirements for reviewer sign-off:
- [ ] Tests are properly located in the test tree.
- [ ] Test descriptions allow a reader to "read only the test plans and evaluate coverage completeness", and accurately reflect the test code.
- [ ] Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
- [ ] Helpers and types promote readability and maintainability.
When landing this PR, be sure to make any necessary issue status updates.
Hey @toji - is this PR ready for review? It's marked draft, but has 3 reviewers assigned. Thanks!
@ben-clayton I'm seeing no reviews requested, just 3 suggestions made by GitHub.
Right you are. Completely unable to parse the GitHub UI
I think it's worthwhile to land this. Kai, could you PTAL?
Any progress on this?
FYI @toji: https://github.com/gpuweb/cts/pull/3844