Test bug: bind group layout with sampleType: "float" and multisampled: true is invalid

Open austinEng opened this issue 3 years ago • 1 comments

We updated the implementation to follow the resolution in gpuweb#3364 and saw the following tests failing due to this validation. Likely the tests are out of date.

[ ] webgpu:api,validation,createBindGroup:binding_must_contain_resource_defined_in_layout:
[ ] webgpu:api,validation,createBindGroup:texture,resource_state:
[ ] webgpu:api,validation,createBindGroup:texture_binding_must_have_correct_usage:
[ ] webgpu:api,validation,createBindGroupLayout:max_resources_per_stage,in_bind_group_layout:maxedEntry={"texture":{"multisampled":false}}
[ ] webgpu:api,validation,createBindGroupLayout:max_resources_per_stage,in_bind_group_layout:maxedEntry={"texture":{"multisampled":true}}
[ ] webgpu:api,validation,createBindGroupLayout:max_resources_per_stage,in_pipeline_layout:maxedEntry={"texture":{"multisampled":false}}
[ ] webgpu:api,validation,createBindGroupLayout:max_resources_per_stage,in_pipeline_layout:maxedEntry={"texture":{"multisampled":true}}
[x] webgpu:api,validation,createBindGroupLayout:multisampled_validation:
[ ] webgpu:api,validation,createBindGroupLayout:visibility:visibility=0
[ ] webgpu:api,validation,createBindGroupLayout:visibility:visibility=1
[ ] webgpu:api,validation,createBindGroupLayout:visibility:visibility=2
[ ] webgpu:api,validation,createBindGroupLayout:visibility:visibility=3
[ ] webgpu:api,validation,createBindGroupLayout:visibility:visibility=4
[ ] webgpu:api,validation,createBindGroupLayout:visibility:visibility=5
[ ] webgpu:api,validation,createBindGroupLayout:visibility:visibility=6
[ ] webgpu:api,validation,createBindGroupLayout:visibility:visibility=7
[ ] webgpu:api,validation,resource_usages,texture,in_pass_encoder:bindings_in_bundle:type0="multisampled-texture";type1="multisampled-texture"
[ ] webgpu:api,validation,resource_usages,texture,in_pass_encoder:bindings_in_bundle:type0="multisampled-texture";type1="render-target"
[ ] webgpu:api,validation,resource_usages,texture,in_pass_encoder:bindings_in_bundle:type0="render-target";type1="multisampled-texture"

Sep 15 '22 21:09 austinEng

@Gyuyoung I checked off the "multisampled_validation" test above that I think you updated.

Sep 20 '22 16:09 kainino0x