Krish Gupta

Results 137 comments of Krish Gupta

> I think your solution kind of beats this anyway doesn't it? Which solution? Can you be specific

Yes, I can implement this on linkfree as well 👍🏻 but the build times will increase a little

> > I don't think this will work because views will not workout this way > > Views ? The counter of views on your profile

Would it not make sense to just have it on the dashboard 🤔 Why would someone else need to have a QR code to my profile. Just my opinion though....

I think #2088 fixed this?

> Is that eslint file to be added? > If yes can I work on this issue!! Yeas, also add a linting workflow, plus fix the linting issues if any.

> I have setup the project but haven't started yet . But I'll make one PR till tomorrow. Take your time 😄

> In which format should I keep eslint file (json or yml)? JS I think.

> ![image](https://user-images.githubusercontent.com/72031540/142017573-cd3eedb1-b262-4147-894f-29c64000e660.png) > > I have done this much what should I do next? How about we copy paste the config from the LinkFree Repo 🙂

> Should I make PR now? And yes when creating PR I should ignore package.json files right? don't ignore package files (eslint is a new dep)