gpt-engineer
gpt-engineer copied to clipboard
Makefile
By using a Makefile
we can abstract some of the things needed to run the app or install it and it is a great place for future commands (like testing)
So I also see a lot of projects us a bat file in addition to a makefile to do installations. What are your thoughts about creating a batch file to run and install?
Sounds good to me although I am not familiar with those, we can add that one in another PR.
I believe .bat
files are for Windows, right?
@AntonOsika @FOLLGAD
WDYT?
If you would like to have something like this let me know and I will amend the README for it
I would suggest having two way of installing, classic python
way (like it is now in the docs) but also the make
way which abstracts things a bit and makes them easier for non pythonistas.
Thanks @patillacode!
I looked yesterday and wanted to ask, do you want to put black commands and pytest commands in here?
Or do you have a simple command to run all the tools in pyproject.toml you prefer?
Also my only concern with Makefiles...
If we change how things are run, we have to keep Makefile in sync.
(And it makes it "harder to find things" since there are so many files)
Thanks @AntonOsika
-
Yes, sometimes it is a bit hard to maintain if we don't keep it simple. I'd say for now just using the Makefile as an alternative to installing would be enough.
-
As for running
black
for example, I leave that to thepre-commit
hooks, I don't think we need amake black
command to runblack
-
For running tests, yes, we should add a
tests
command so when you domake tests
it runs them. -
I will edit the
README.md
so people know there is now a Makefile that they can use to install and run the project
@patillacode @AntonOsika I can document the makefile because it is very crucial step in setting up the codebase for development and a proper documentation is needed