gphoto2 icon indicating copy to clipboard operation
gphoto2 copied to clipboard

Add CI test build as github workflow action

Open ndim opened this issue 2 years ago • 2 comments

ndim avatar Jun 22 '22 04:06 ndim

So make check fails when built with libexif support:

https://github.com/gphoto/gphoto2/runs/6997551110?check_suite_focus=true#step:3:119

libexif-dev is already the newest version (0.6.21-6ubuntu0.4).
libexif-dev set to manually installed.

https://github.com/gphoto/gphoto2/runs/6997551110?check_suite_focus=true#step:7:331

*** Running "EXIF display" test
++ ../gphoto2/gphoto2 '--camera=Directory Browse' --port=disk:./staging --show-exif=4
+ EXITCODE=0
+ set +x
Test test037 FAILED: unexpected output
--- ./data/test037.result	2022-06-22 04:47:43.535352876 +0000
+++ /home/runner/work/gphoto2/gphoto2/tests/log/test037.out	2022-06-22 04:48:30.337787441 +0000
@@ -16,7 +16,7 @@
 ComponentsConfigurat|Y Cb Cr -                                                  
 UserComment         |Public domain EXIF test image                              
 FlashPixVersion     |FlashPix Version 1.0                                       
-ColorSpace          |Uncalibrated                                               
+ColorSpace          |Internal error (unknown value 65535)                       
 PixelXDimension     |32                                                         
 PixelYDimension     |32                                                         
 --------------------+-----------------------------------------------------------

ndim avatar Jun 22 '22 04:06 ndim

As make check works for me locally, I have checked my local libexif version: 0.6.24-2.fc36.x86_64 versus the CI system Ubuntu OS's 0.6.21-6ubuntu0.4 where the difference occurs and make check fails:

-ColorSpace          |Uncalibrated                                               
+ColorSpace          |Internal error (unknown value 65535)                       

How serious is this? Should gphoto2's make check actually fail here?

ndim avatar Jun 22 '22 05:06 ndim