slack-webhook icon indicating copy to clipboard operation
slack-webhook copied to clipboard

Published 20 hours ago • verified publisher icon gpedro

Fix SlackAction: change SlackAction "value" to "url"

Open dvehar opened this issue 6 years ago • 10 comments

Using "value" does not work (maybe it used to). Example

Using "url" does work. Example

dvehar avatar Jun 13 '18 23:06 dvehar

@gpedro @galimru please review

dvehar avatar Jun 13 '18 23:06 dvehar

Hi @dvehar, the value is needed for interactive message buttons as response value to help determine which button was pressed. When you use url field it will create link button like described here https://api.slack.com/docs/message-attachments#link_buttons I think it would be better to add url field and leave other fields as is.

rgalimov avatar Jun 19 '18 12:06 rgalimov

@rgalimov I pushed some changes. I broke out the SlackAction functionality into specific subclasses (BasicButtonSlackAction, InteractiveButtonSlackAction, InteractiveSelectSlackAction) and added tests.

dvehar avatar Jun 22 '18 17:06 dvehar

@rgalimov can you please review?

dvehar avatar Jul 13 '18 04:07 dvehar

@dvehar this looks fine

galimru avatar Jul 13 '18 06:07 galimru

@gpedro please review / merge.

dvehar avatar Jul 13 '18 06:07 dvehar

@gpedro just following up. Can this change be merged?

dvehar avatar Jul 21 '18 22:07 dvehar

@gpedro @galimru Can these changes be merged?

deepakputhraya avatar Aug 28 '18 16:08 deepakputhraya

@gpedro @jaypatel512 @rgalimov are you able to merge?

dvehar avatar Feb 04 '19 02:02 dvehar

@dvehar Sorry, I don't have access to merge PR

rgalimov avatar Feb 04 '19 08:02 rgalimov