MSTerminalSettings icon indicating copy to clipboard operation
MSTerminalSettings copied to clipboard

WIP: Added support for Windows Terminal v0.11.1121.0 or newer

Open jkrgr0 opened this issue 4 years ago • 3 comments

In version 0.11.1121.0 of Windows Terminal the profiles.json has been renamed to settings.json (See microsoft/terminal Release notes).

To support this change and also to support older releases, I've added a internal function which determines the configuration file path for Windows Terminal.

jkrgr0 avatar May 07 '20 19:05 jkrgr0

I've determined, that also the structure of the profile list has slightly changed. I will adding support for this the next days and keep pushing the changes to this branch. So the pull request is WIP

jkrgr0 avatar May 07 '20 19:05 jkrgr0

@wav3 yes there have been many changes, we are working on a complete refactor for 2.0: https://github.com/JustinGrote/MSTerminalSettings/tree/refactor/QuickType

If you get this fixed for the existing implementation, it can be maintained for the 1.0 branch, otherwise you can try the 2.0 preview

JustinGrote avatar May 07 '20 20:05 JustinGrote

To be honest, I didn't even notice the other branches..

On the first view it does not seems to be too complex to fix the settings json for the existing implementation. I will dig deeper in this on the weekend.

jkrgr0 avatar May 07 '20 20:05 jkrgr0