Gregory Anders
Gregory Anders
@znd4 Is this ready for review?
I mentioned in https://github.com/nvim-neo-tree/neo-tree.nvim/issues/1290 why I don’t think this is the right solution (or even necessary). The neo-tree issue is closed, does this PR still actually solve any problem?
>If we have to do anything, we should rename underline -> highlight. Agreed, we should do this.
> seems like an easy change where we just rename underline to highlight [here](https://github.com/neovim/neovim/blob/b9cf3880455c6ee2c3e9cc9a9d2ad2694c075ec4/runtime/lua/vim/diagnostic.lua). is that all? It is not so easy, because we must continue to support `underline` (as...
>I'd imagine it could be done by duplcating the relevant code and marking everything with ...underline... as @deprecated and then removing the deprecated code after two releases. No it's not...
https://github.com/neovim/neovim/pull/24499#issuecomment-1658752117 mentions a `vim.goto()` or `vim.cursor()` function which abstracts over the concept of "moving the cursor to a position" and accepts a ["position"](https://github.com/neovim/neovim/issues/25509) object as an argument. I do think...
Re-opening in light of the revival of https://github.com/neovim/neovim/pull/16230. `vim.diagnostic.jump({ count = math.max, wrap = false })` can be used for "goto last" (similar for "goto first").
No need to have separate, redundant `if` branches: ```lua if not w then vim.cmd(opts.command or ('%s 60vnew'):format(vim.o.splitright and 'botright' or 'topleft')) end ``` >We could also leave out the topleft/botright...
> What's the rationale for using `topleft` by default? Do you mean as opposed to `botright`? Arbitrary I suppose. IIRC the `nvim-treesitter/playground` plugin opens to the left too (at least...
>Then user can do :vertical InspectTree and similar. This is a good idea. The implementation of `:InspectTree` needs to be modified to pass along the `mods` field to `vim.treesitter.inspect_tree()` though....