world-of-might-and-magic icon indicating copy to clipboard operation
world-of-might-and-magic copied to clipboard

PCX::Encode doesnt check against max buffer size

Open pskelton opened this issue 2 years ago • 1 comments

Describe the bug PCX encoding functions never check for buffer overrun

Expected behavior Throw error if buffer size exceeded

pskelton avatar Jun 06 '22 18:06 pskelton

Also we need to just pass pointer and move output's buffer allocation to encoder so it can properly allocate required buffer according to requested encoding format and image resolution. And get rid of all these hardcoded buffer sizes.

CkNoSFeRaTU avatar Jun 18 '22 20:06 CkNoSFeRaTU