world-of-might-and-magic icon indicating copy to clipboard operation
world-of-might-and-magic copied to clipboard

quick_saves_count setting ignored and overwritten

Open Novicek opened this issue 1 year ago • 3 comments

Describe the bug The setting quick_saves_count in openenroth.ini doesn't do anything. There are always 5 quicksaves.

To Reproduce Steps to reproduce the behaviour:

  1. Change the setting to any different number other than 5.
  2. Delete existing quicksaves
  3. Start the game
  4. Spam quicksave
  5. Go to load game and see that there are 5 quicksaves irrespective of the setting

Expected behavior The game should only create as many quicksaves as set in the .ini.

Environment (please complete the following information):

  • OS: Windows 11, 64-bit

Additional context There seems to be an extra bug where certain numbers get overwritten. If I set the saves count to 10 and restart the game (no need to load or save game), the number changes to a random different one in the .ini (so far got 3, 2 and 4).

Novicek avatar Dec 27 '23 18:12 Novicek

Can see the error with the validation. Will look at number skipping error too.

pskelton avatar Dec 27 '23 18:12 pskelton

Scratch that. Having looked at this properly, behavior is currently as intended. "quick_saves_count" is an engine internal number to keep track of what quick save its on. The total number of quick saves will always be 5.

Will wait for input on whether we should hide or rename this in config, and, whether the number of quick saves the engine will allow should be configurable.

pskelton avatar Dec 27 '23 22:12 pskelton

Scratch that. Having looked at this properly, behavior is currently as intended. "quick_saves_count" is an engine internal number to keep track of what quick save its on. The total number of quick saves will always be 5.

Will wait for input on whether we should hide or rename this in config, and, whether the number of quick saves the engine will allow should be configurable.

Right, that makes sense now. Maybe just rename it.

And yeah, if I may suggest, do have the number of quicksaves configurable, often times games let you do that (I prefer having only 1 quicksave for example)

Novicek avatar Dec 27 '23 22:12 Novicek