java-stream-player

java-stream-player copied to clipboard

Why do you test for open?

1

https://github.com/goxr3plus/java-stream-player/blob/4991e4acc52041ca1529404d176c57b4171eba94/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L529 On the line above the test, you just opened the sourceDataLine. Don't you trust that it worked? If it didn't work, if the line wasn't opened, isn't that a...

HelgeStenstrom

What to do if null?

1

https://github.com/goxr3plus/java-stream-player/blob/4991e4acc52041ca1529404d176c57b4171eba94/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L523 Why is this test for nullity there? If sourceDataLine is null, the whole method openLine() does nothing, silently. Isn't that an error condition? Isn't it better to let a...

HelgeStenstrom

Improve JavaDoc for StreamPlayerListener.progress

4

https://github.com/goxr3plus/java-stream-player/blob/4991e4acc52041ca1529404d176c57b4171eba94/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayerListener.java#L43-L49 Try to answer at least these questions: - When and how often is progress() called? Who is the caller? - Clarify nEncodedBytes the n encoded bytes. Does it mean...

HelgeStenstrom

getGainValue() returns wrong value.

2

https://github.com/goxr3plus/java-stream-player/blob/ea4b7d9fda27f81902a0774a2535842ead6c622a/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L1096-L1099 At least it doesn't return the value set by setGain(), which is confusing. After reading the code, I realize that the internal gainControl probably has a setting on a...

HelgeStenstrom

Change Volatile

3

Volatile fields: https://github.com/goxr3plus/java-stream-player/blob/a4aaa94c19f99da6ae46cb2bca60bae62aa41b40/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L72 https://github.com/goxr3plus/java-stream-player/blob/a4aaa94c19f99da6ae46cb2bca60bae62aa41b40/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L78 https://github.com/goxr3plus/java-stream-player/blob/a4aaa94c19f99da6ae46cb2bca60bae62aa41b40/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L111 SonarLint says that you should remove volatile from these fields. See https://wiki.sei.cmu.edu/confluence/display/java/CON50-J.+Do+not+assume+that+declaring+a+reference+volatile+guarantees+safe+publication+of+the+members+of+the+referenced+object IntelliJ complains about non-atomic operation on volatile field, probably as a consequence. https://github.com/goxr3plus/java-stream-player/blob/a4aaa94c19f99da6ae46cb2bca60bae62aa41b40/src/main/java/com/goxr3plus/streamplayer/stream/StreamPlayer.java#L483...

HelgeStenstrom

https://github.com/goxr3plus/java-stream-player/blob/aea1720538cb972e6550a762d82345ce83a2db78/src/test/java/com/goxr3plus/streamplayer/tools/TimeToolTest.java#L45-L46 The method TimeTool.millisecondsToTime(millis) convert an integer, representing a number of milliseconds, to a string. It's unclear from the JavaDoc of the method, what the intention was. The JavaDoc has...

HelgeStenstrom

How can the player be stopped?

4

I can't find how to stop the player. When I run Main.main(), it continues to sound after main() exits. The only way I have found is to call System.exit(). How...

HelgeStenstrom

Seeking by timestamp, not by byte

12

Are there any way to seek by specifying timestamp (for example, seek to 1:17 (1 min 17 secs) point or something)? Currently I can only find seek() function that receives...

TonalidadeHidrica

ExecutorService is not shut down

6

First of all thanks for the work on this project - works wonderfully. I used it in a JavaFX application and noticed, that after calling Platform.exit(), the process was still...

IARI

Unused code

4

I am currently trying to re-implement a player based on Javax.soundand thus trying to understand the implementation here, In the course of that process, I stumbled upon a piece of...

IARI