font-awesome-webpack icon indicating copy to clipboard operation
font-awesome-webpack copied to clipboard

Webpack 4 breaks font-awesome-webpack...

Open jarecsni opened this issue 6 years ago • 16 comments

Due to this module depending on an old version of less-loader.

Does anyone know of a fork supporting webpack 4 as this project seems to be defunct?

jarecsni avatar Mar 25 '18 01:03 jarecsni

I forked this project and updated the dependencies, which solved the build problem. Not sure if it makes sense to raise a PR here.

jarecsni avatar Mar 26 '18 06:03 jarecsni

why did i become a web developer

why

komali2 avatar Apr 12 '18 05:04 komali2

@jarecsni , thanks for making that fork!

I tested it out using

$ yarn add font-awesome-webpack@https://github.com/jarecsni/font-awesome-webpack#440af2a2efe7ba1779d039556f04538e57bad4bb --dev

and all is working for me. I think you should make a PR for the dependency upgrade, IMO. 👍

thescientist13 avatar Apr 17 '18 12:04 thescientist13

I too have tested it out as above. And it is working fine. So If you can make a PR, that would be great!

JoelParke avatar Apr 23 '18 19:04 JoelParke

@jarecsni I think a pull request would be good.

JoelParke avatar May 06 '18 20:05 JoelParke

@jarecsni Please make a PR, this would be very helpful to people still using this.

Are there alternatives?

nstrelow avatar Jul 05 '18 17:07 nstrelow

I forked @jarecsni fork to do the PR : https://github.com/gowravshekar/font-awesome-webpack/pull/42 wait & see.

eregnier avatar Jul 19 '18 08:07 eregnier

thanks @eregnier !

thescientist13 avatar Jul 20 '18 23:07 thescientist13

Any pointers on how to obtain the patch or fork to make font-awesome work with webpack 4 right now? I'm not yet quite up to speed with the flow of things around here I'm afraid :(

bparticle avatar Jul 24 '18 06:07 bparticle

@bparticle you can install @jarecsni fork with up to date version using something like

npm i [email protected]:jarecsni/font-awesome-webpack.git

until I hope his fork is merged to the upstream repository.

eregnier avatar Jul 24 '18 07:07 eregnier

@eregnier Thanks for your answer. I'm getting this error, even though the repository does contain a package.json file: Could not install from "github.com:jarecsni/font-awesome-webpack.git" as it does not contain a package.json file.

bparticle avatar Jul 24 '18 08:07 bparticle

indeed, there is an issue with npm and git URI.

instead, try :

npm i https://github.com/jarecsni/font-awesome-webpack.git

I tried it this time and it works for me.

eregnier avatar Jul 24 '18 09:07 eregnier

My fork:

https://www.npmjs.com/package/font-awesome-webpack-4

"font-awesome-webpack-4": "1.0.0",

tapz avatar Aug 15 '18 14:08 tapz

thank you @tapz 🙏

Will give it a try and let you know!

thescientist13 avatar Aug 16 '18 00:08 thescientist13

Awesome @tapz -- I am not using this directly and have removed my fork!

JoelParke avatar Aug 18 '18 01:08 JoelParke

A SASS version would be beautiful.

JamesTheHacker avatar Aug 31 '18 18:08 JamesTheHacker