govim icon indicating copy to clipboard operation
govim copied to clipboard

Published 20 hours ago • verified publisher icon govim

cmd/govim: fix gopls codelens setting

Open stamblerre opened this issue 4 years ago • 3 comments

https://golang.org/cl/273308 fixes a misspelling, which causes a govim test to fail.

stamblerre avatar Nov 30 '20 20:11 stamblerre

Thank you! We are a little bit in a "chicken and egg" situation here since this PR depends on govim updating tools to a version that includes CL273308, and updating is blocked by golang/go#42837.

I took a look at CL273308 and it looks like having the old name shouldn't break the tests to fail (yet), as per Heschis comment, which govim test is it that doesn't work?

leitzler avatar Dec 01 '20 16:12 leitzler

The failing test is TestScripts/scenario_default/suggested_fixes -- it doesn't expect the pop-up that says the setting is deprecated and replaced. Do you know if https://golang.org/cl/274241/ resolved https://github.com/golang/go/issues/42837?

stamblerre avatar Dec 01 '20 18:12 stamblerre

I see! Don't know yet, GitHub Actions seems to have a major outage.. I'll update you both when I know!

leitzler avatar Dec 01 '20 18:12 leitzler