website icon indicating copy to clipboard operation
website copied to clipboard

Add fallback for missing head of institution name

Open Rahul2322-P opened this issue 2 months ago • 15 comments

Made a small update to improve how we pull the head of an institution:

-->Added a few fallback properties like chair (P488), CEO (P169), director (P1037), and Secretary-General (P3975) -->Also added a COALESCE so if the name’s missing, it’ll show “Not Available” instead This should help keep the results meaningful even when the main leader info isn’t there. Appreciate you taking the time to review it!

Rahul2322-P avatar Oct 30 '25 05:10 Rahul2322-P

Hey @Ainali,

I’ve made the requested updates:

-->Split the office (P2388, P1313) and person-based properties (P488, P169, P1037, P3975) into separate blocks.

-->Removed the COALESCE fallback, since the frontend handles missing data.

Everything should now work as expected. Please have a look when you get a chance. Thanks!

Rahul2322-P avatar Oct 30 '25 11:10 Rahul2322-P

-->Removed the COALESCE fallback, since the frontend handles missing data.

It looks like you forgot to remove it.

Ainali avatar Oct 30 '25 11:10 Ainali

Hi @Ainali — I’ve now removed the COALESCE fallback from ?leadBy as requested. Everything else is unchanged. Please review when you get a chance. Thanks!

Rahul2322-P avatar Oct 31 '25 14:10 Rahul2322-P

Hi @Ainali, I’ve pushed the latest commit removing the COALESCE fallback as you requested. All checks are passing and there are no conflicts. Could you please review and approve when you get a chance? Thank you!

Rahul2322-P avatar Nov 01 '25 09:11 Rahul2322-P

@Rahul2322-P Have you tried these changes locally?

Ainali avatar Nov 01 '25 10:11 Ainali

Thanks @Ainali for the approval and local test confirmation. I’ll wait for @Abbe98’s review to make sure everything is aligned before merge. Appreciate your time!

Rahul2322-P avatar Nov 01 '25 10:11 Rahul2322-P

Thanks @Ainali for the approval and local test confirmation.

I would still appreciate an answer if you tried this locally.

Ainali avatar Nov 01 '25 10:11 Ainali

Thanks, @Ainali! I ran local tests on my end too — checked multiple country entries to confirm the fallback logic and lead_by additions behave as expected without breaking anything else. I'll hold off on merging until @Abbe98 gives the green light, just to be sure everything lines up. Really appreciate your thorough review and the extra eyes!

Rahul2322-P avatar Nov 01 '25 15:11 Rahul2322-P

I'll hold off on merging

That's odd. You shouldn't even have the rights to merge.

Ainali avatar Nov 01 '25 15:11 Ainali

Thanks everyone for reviewing. Everything looks good on my end and the tests confirm expected behavior. I’ll hold off until @Abbe98 gives the final go-ahead. Really appreciate the quick feedback and the labels!

Rahul2322-P avatar Nov 01 '25 15:11 Rahul2322-P

Hi @Abbe98 --> just following up to see if you had a chance to review this. It’s already approved by @Ainali and verified locally on both ends. Appreciate your time.

Rahul2322-P avatar Nov 04 '25 05:11 Rahul2322-P

Hi @Abbe98 --> just following up to see if you had a chance to review this. It’s already approved by @Ainali and verified locally on both ends. Appreciate your time.

Chill. Spamming with comments does not help anyone. (Don't reply to this comment either.)

Ainali avatar Nov 04 '25 06:11 Ainali

Thanks @Abbe98 I will cleaned up the extra line breaks as requested. Please let me know if it looks good now.

Rahul2322-P avatar Nov 06 '25 16:11 Rahul2322-P

Hi @Abbe98 — just following up to check if the cleanup looks good now. Everything’s updated and verified locally. Appreciate your time and review!

Rahul2322-P avatar Nov 13 '25 02:11 Rahul2322-P

There is still a odd line in the OPTIONAL section.

Abbe98 avatar Nov 14 '25 16:11 Abbe98