website icon indicating copy to clipboard operation
website copied to clipboard

Make the infobox expandable #102

Open Abbe98 opened this issue 1 year ago • 4 comments

Description

Display official blog URL and official jobs URL (#287) as a start.

Issue Reference

Fixes #102 #287

PR Details

Type of Change

  • [ ] Bug fix
  • [x] New feature
  • [ ] Breaking change
  • [ ] Documentation update
  • [ ] Code refactor

Checklist

Please ensure the following before submitting the PR:

  • [x] I have tested the changes locally, and they work as expected.
  • [x] The code follows the project's coding standards and conventions.

Screenshots (applicable to user interface changes)

Screencast from 2024-12-08 17-06-18.webm Screencast from 2024-12-08 17-05-58.webm

Abbe98 avatar Dec 08 '24 16:12 Abbe98

I was trying to build locally but got this error:

Building project with 47 views.
Received bad(HTTP: 502 Bad Gateway) response from SPARQL endpoint:
<html><body><h1>502 Bad Gateway</h1>
The server returned an invalid or incomplete response.
</body></html>

Error: Failed to render page at site/statistics/index.html Error: template: statistics.html:37:35: executing "main" at <query "organization-optional.rq" .qid.String>: error calling query: Received bad response from SPARQL endpoint

Ainali avatar Dec 08 '24 18:12 Ainali

I was trying to build locally but got this error:

Building project with 47 views.
Received bad(HTTP: 502 Bad Gateway) response from SPARQL endpoint:
<html><body><h1>502 Bad Gateway</h1>
The server returned an invalid or incomplete response.
</body></html>

Error: Failed to render page at site/statistics/index.html Error: template: statistics.html:37:35: executing "main" at <query "organization-optional.rq" .qid.String>: error calling query: Received bad response from SPARQL endpoint

Looks like WDQS is having a bad day.

Abbe98 avatar Dec 08 '24 18:12 Abbe98

Converted to draft until I have changed it so that the "expand" button only renders when there is additional data to be displayed. I will also create an issue about a generic "[missing data]" (or something positive? "add information"?) replacement.

Abbe98 avatar Dec 08 '24 18:12 Abbe98

I'm scratching my head a little bit regarding the design here. If we only want to display this if there is information we end up in a situation in which we either show a loading indicator and a "fail message" or we end up with a jumpy behavior when the "expand" renders. I'm not a fan of either.

Maybe if we first turn the [missing data] messages into a call to action "[add information->]" it's more acceptable to always show this even if there is no additional information?

Abbe98 avatar Apr 25 '25 13:04 Abbe98