website icon indicating copy to clipboard operation
website copied to clipboard

"Led by" should take "office held by head of government" into account

Open Abbe98 opened this issue 4 years ago • 6 comments

Description

Example item affected: https://www.wikidata.org/wiki/Q1002006

Abbe98 avatar Oct 01 '21 10:10 Abbe98

I guess this one is solved?

toukirkhan avatar Oct 01 '22 21:10 toukirkhan

No, we have not solved this one yet. See https://www.govdirectory.org/south-africa/Q1002006/ for live data.

Ainali avatar Oct 01 '22 21:10 Ainali

I can definitely solve this please assign me

toukirkhan avatar Oct 01 '22 22:10 toukirkhan

Solved this in PR #243

toukirkhan avatar Oct 01 '22 22:10 toukirkhan

Hmm, perhaps I was wrong and this one is already solved. Looking at these two that behave as expected:

https://www.wikidata.org/wiki/Q1185115 https://www.govdirectory.org/south-africa/Q1185115/

@Abbe98 Is there something more to do on this one?

Ainali avatar Oct 02 '22 08:10 Ainali

Please tell me if you have more good first issues.

On Sun, 2 Oct, 2022, 1:46 pm Jan Ainali, @.***> wrote:

Hmm, perhaps I was wrong and this one is already solved. Looking at these two that behave as expected:

https://www.wikidata.org/wiki/Q1185115 https://www.govdirectory.org/south-africa/Q1185115/

@Abbe98 https://github.com/Abbe98 Is there something more to do on this one?

— Reply to this email directly, view it on GitHub https://github.com/govdirectory/website/issues/134#issuecomment-1264581940, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVGH3Q64FXSQYQZTQ5OFAZTWBFAGBANCNFSM5FENJNBQ . You are receiving this because you commented.Message ID: @.***>

toukirkhan avatar Oct 02 '22 08:10 toukirkhan