design-system-components icon indicating copy to clipboard operation
design-system-components copied to clipboard

Pancake generated React components can not be used natively in Create React App

Open wibily opened this issue 5 years ago • 2 comments

Bug Report

  • [x] I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
  • [x] I’ve read and agree to the Code of Conduct.
  • [x] I’ve searched for any related issues and avoided creating a duplicate issue.

What happened

Create React App is the easiest way to bootstrap a new React project with sensible defaults. ESLint automatically runs in this configuration with rules defined in the ESLint config react app repository.

Now if i wanted to use the pancake generated Design System components inside my create-react-app bootstrapped project, the pancake generated React code will need to be ESlint compliant.

What I expected to happen

I expect the pancake generated React components to work natively in my create react app bootstrapped project

Reproducing

Steps to reproduce:

  1. Create a new create-react-app project. Instructions here
  2. Run npm install for all the Design system components
  3. Configure the pancake react to generated the components in my src/ directory so that i can reference them in my create-react-app project
  4. Import all the pancake react components in my index.js file
  5. Run npm start in my create react app project
  6. Observe that eslint errors prevent the project from starting.

Attachments

Reproduction repo here

wibily avatar Jan 03 '20 04:01 wibily

There was an attempted previously: https://github.com/govau/design-system-starter-react

svict4 avatar Jun 12 '20 12:06 svict4

Also noteworthy that there are a few Government projects using the designsystem in Gatsby

svict4 avatar Jun 12 '20 12:06 svict4