design-system-components icon indicating copy to clipboard operation
design-system-components copied to clipboard

Rename `packages` -> `components`

Open azerella opened this issue 5 years ago • 5 comments

packages is quite an old name, for a new starter looking at this repo it's immediately more obvious if our components are under a component/ folder.

azerella avatar Apr 10 '19 01:04 azerella

Along with that, I think that tests should probably be renamed to demo. tests normally suggests tests written in a testing framework.

HurricaneInteractive avatar Apr 14 '19 23:04 HurricaneInteractive

@HurricaneInteractive It's a good point, I don't know if demo is the right word either though, the folders listed under tests are used for visual testing, not really a preview 🤔

azerella avatar Apr 14 '19 23:04 azerella

I don't think any of those 3 work.. Is the only current tests for a11y (when you run npm run test)? If that is the case, if additional react/js tests were to be written, a possible solution is to create a top level tests folder could be created. Although that would be kinda annoying because you are separating the component from the tests.

OR in (packages|components)/<component>/src/js you could create react.test.js etc files for your component tests. That way your functionality and tests are contained within the same folder and you still have your visual tests.

HurricaneInteractive avatar Apr 15 '19 01:04 HurricaneInteractive

The demos are in the design system documentation website. These are just tests for us to see the components in different contexts

sukhrajghuman avatar Apr 15 '19 01:04 sukhrajghuman

Thus issue is open i want to work on this @adamzerella

AmanDeep9925 avatar Jun 01 '19 17:06 AmanDeep9925