RabbitMQ 3.12.x compatibility

[lukebakken]

Fixes #61

Update erlang.mk and rabbitmq-components.mk

[lukebakken]

cc @essen @lhoguin @michaelklishin

I'm having an issue after updating erlang.mk and rabbitmq-components.mk from the v3.12.x branch of rabbitmq/rabbitmq-server. The build process is trying to generate CLI scripts and deps/rabbitmq_cli is not present. Seems like a step that shouldn't be happening:

make-output.txt

gmake[1]: Leaving directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/rabbit_common'
gmake[1]: Entering directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/amqp_client'
 DEPEND amqp_client.d
 ERLC   amqp_auth_mechanisms.erl amqp_channel.erl amqp_channel_sup.erl amqp_channel_sup_sup.erl amqp_channels_manager.erl amqp_client.erl amqp_connection.erl amqp_connection_sup.erl amqp_connection_type_sup.erl amqp_direct_connection.erl amqp_direct_consumer.erl amqp_gen_connection.erl amqp_gen_consumer.erl amqp_main_reader.erl amqp_network_connection.erl amqp_rpc_client.erl amqp_rpc_server.erl amqp_selective_consumer.erl amqp_ssl.erl amqp_sup.erl amqp_uri.erl amqp_util.erl rabbit_routing_util.erl uri_parser.erl
 APP    amqp_client
 GEN    install-cli-scripts
 GEN    install-cli-escripts
gmake[2]: Entering directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/amqp_client'
gmake[2]: *** /home/lbakken/development/gotthardp/rabbitmq-email/deps/rabbitmq_cli: No such file or directory.  Stop.
gmake[2]: Leaving directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/amqp_client'
gmake[1]: *** [/home/lbakken/development/gotthardp/rabbitmq-email/deps/rabbit_common/mk/rabbitmq-dist.mk:290: install-cli-escripts] Error 2
gmake[1]: Leaving directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/amqp_client'
gmake: *** [erlang.mk:3750: deps] Error 2

[lukebakken]

Aha, it is this commit that is causing this issue:

https://github.com/rabbitmq/rabbitmq-server/commit/d24315de559f687b427b3164aca8b9c476e8c951

cc @dumbbell

[lukebakken]

@dumbbell Changing that line back to dist results in this error:

lbakken@PROKOFIEV ~/development/gotthardp/rabbitmq-email (rabbitmq-server-v3.12.x=)
$ make
erlang.mk:4854: warning: overriding recipe for target '/home/lbakken/development/gotthardp/rabbitmq-email/deps/amqp_client'
erlang.mk:4392: warning: ignoring old recipe for target '/home/lbakken/development/gotthardp/rabbitmq-email/deps/amqp_client'
erlang.mk:4854: warning: overriding recipe for target '/home/lbakken/development/gotthardp/rabbitmq-email/deps/eiconv'
erlang.mk:4392: warning: ignoring old recipe for target '/home/lbakken/development/gotthardp/rabbitmq-email/deps/eiconv'
gmake[1]: Entering directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/rabbit_common'
 DEPEND rabbit_common.d
gmake[1]: Leaving directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/rabbit_common'
gmake[1]: Entering directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/amqp_client'
 DEPEND amqp_client.d
gmake[1]: Leaving directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/amqp_client'
gmake[1]: Entering directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/rabbit'
 DEP    rabbitmq_cli (rabbitmq-server-v3.12.x)
ln -s /home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/rabbitmq_cli /home/lbakken/development/gotthardp/rabbitmq-email/deps/rabbitmq_cli;
 DEP    rabbitmq_prelaunch ()
Error: Unknown or invalid dependency: rabbitmq_prelaunch.
gmake[1]: *** [../../erlang.mk:4396: /home/lbakken/development/gotthardp/rabbitmq-email/deps/rabbitmq_prelaunch] Error 78
gmake[1]: Leaving directory '/home/lbakken/development/gotthardp/rabbitmq-email/.erlang.mk/rabbitmq-server/deps/rabbit'
gmake: *** [erlang.mk:3750: deps] Error 2

[dumbbell]

I don't know how plugins should be compiled nowadays after the switch to the monorepository in rabbitmq-server, but I'm not sure it is still possible to build it outside of the rabbitmq-server umbrella. Rin may know, but I can't ping her from this issue apparently.