gitlab-copy icon indicating copy to clipboard operation
gitlab-copy copied to clipboard

Published 20 hours ago • verified publisher icon gotsunami

Remove pagination limit on label copy

Open skwi opened this issue 5 years ago • 4 comments

While transfering a large amount of labels, I found my self limited to 20 by the Gitlab API pagination.

This PR fixes this issue by fetching label with a page loop.

skwi avatar Mar 14 '19 15:03 skwi

Thanks @skwi! Before I merge your patch, would you mind adding some UT using fakeClient and the gitlab.GitLaber interface? To validate the patch. Thanks!

matm avatar Mar 16 '19 15:03 matm

Yes I will. I should be able to find time this week to write the UT.

To be honest, this is the first time I write code in Go so I need some time to find out why UT are now failing, but I'm working on it.

skwi avatar Mar 18 '19 08:03 skwi

To be honest, this is the first time I write code in Go so I need some time to find out why UT are now failing, but I'm working on it.

No worries, thanks for your contribution.

matm avatar Mar 18 '19 08:03 matm

Related to #53

matm avatar Mar 04 '23 13:03 matm