komga icon indicating copy to clipboard operation
komga copied to clipboard

User Rights for metadata edition

Open D1skanime opened this issue 4 years ago • 13 comments

I have a large collection of comix, mangas and artbooks. I share this collection with my friends who have access to Komga. My friends often ask me if it would be possible for them to add a description, author, etc. and also rate the content. I still have the time to edit every single content and add a description. Since we are German speaking I can't use the common scrappers that search for English information.

Describe the solution you'd like

With such a large collection, it would be ideal if others could collaborate in creating and editing the Serie and books information. Moreover, even a lot of detailed information is not found by the standard crawlers. So that by manually compiling you can create a much more detailed database than you have on the common comix pages.

User Storie

As an admin, I can give a user the role "series write permissions" so that the user can edit series and books.

  • In the system settings, User Management there is another checkbox
  • checkbox: series write permissions
  • if the admin klick the checkbox and safe the User has writing rights on books and series
  • if the admin unckeck the checkbox and save the user has no writing rights

User Storie

As a logged in user with the Role series write permissions, I can create, delete, edit and safe the series and books information.

The user sees a pen symbol on the series. If he clicks on it a tap window opens with two Buttons on the left side.

  • Buttonname General
  • Buttonname Task

If user klick on the General Button he can edit / delete or create new

  • Title
  • Sort title
  • Summary
  • Language
  • Reading Direction
  • Publisher
  • Age Rating
  • Status -->Since the admin is the only one who creates series and provides books, he is also the only one who knows when the series is finished. Therefore, the question arises whether the user should adjust this information?

if the User klick on the Task he can edit / delete or create

  • Genres
  • Tags

on the tap window it has a save and cancel Button

  • If the User klick on the safe Button all changes are saved and the typ windows close
  • if the user klick on the Cancel Button nothing will be safed and the tap windows close

book

The user sees a pencil icon on the book. If he clicks on a tap window opens with three Buttons on the left side.

  • Buttonname General
  • Buttonnaame Authors
  • Buttonname Task

If user klick on the General Button he can edit / delete or create new

  • Title
  • Number
  • sort number
  • Summary
  • Release Date
  • ISBN

If user klick on the Authors Button he can edit / delete or create new

  • Writers
  • Pencillers
  • Colorists
  • Letterers
  • Cover
  • Editors

if the User klick on the Task he can edit / delete or create

  • Tags

on the tap window it has a save and cancel Button

  • If the User klick on the safe Button all changes are saved and the typ windows close
  • if the user klick on the Cancel Button nothing will be safed and the tap windows close

D1skanime avatar Sep 12 '21 12:09 D1skanime

Status -->can not change

Why the restriction on this field?


What do you mean by "main content" and "sub content" ?


User rating has already been requested in #623 and #58

gotson avatar Sep 13 '21 03:09 gotson

Why the restriction on this field? Because the admin decides about the status whether completed or still running

Main Content --> Gaston Sub Content --> Gaston Volume 1 Sub Content --> Gaston Volume 2

D1skanime avatar Sep 13 '21 21:09 D1skanime

Because the admin decides about the status whether completed or still running

Then why would the admin not decide on other fields too? That seems arbitrary in your own use case, but doesn't seem scalable to other people who may have other needs.

Main Content --> Gaston Sub Content --> Gaston Volume 1 Sub Content --> Gaston Volume

Please use the Komga wording then : series and books. Could you update the issue to reflect this, so it's clear to everyone?

gotson avatar Sep 13 '21 23:09 gotson

Yes i can do this, thx for sharing this info

D1skanime avatar Sep 14 '21 09:09 D1skanime

Thanks for the update and detailed user stories. I still don't understand the limitation on the series status. Yes, only the admin will add books, but from the look of it the admin is a lazy bunch that delegates the metadata management to his pals, said pals could lookup the series information online and update the status.

gotson avatar Sep 15 '21 13:09 gotson

"said pals could lookup the series information online and update the status." I agree , You are absolutely right

D1skanime avatar Sep 15 '21 22:09 D1skanime

Here are all the actions that are currently restricted to admininstrator role. In bold the ones I thing should be delegated to a Contributor/Curator role.

Book

  • Analyze book
  • Refresh metadata for book
  • Update book metadata
  • Import book

Series

  • Analyze series
  • Refresh metadata for series
  • Update series metadata
  • Add poster artwork
  • Select poster artwork as selected
  • Delete user uploaded poster artwork

Library

  • Add library
  • Edit library
  • Delete library
  • Empty trash for a library
  • Scan library
  • Analyze library
  • Refresh metadata for library

Collections

  • add
  • update
  • delete

Read lists

  • add
  • update
  • delete
  • import from ComicRack CBL file

I don't list the rights on users and tasks, as it's purely admin.

I am not sure about the rights to edit Collections and Read Lists. What's your take on that?

gotson avatar Sep 24 '21 02:09 gotson

I don't list the rights on users and tasks, as it's purely admin. ""I am not sure about the rights to edit Collections and Read Lists. What's your take on that?""

What exactly do you mean by that? I think so it is okay if he can only do the bold things

D1skanime avatar Sep 24 '21 22:09 D1skanime

""I am not sure about the rights to edit Collections and Read Lists. What's your take on that?""

What exactly do you mean by that? I think so it is okay if he can only do the bold things

I mean, should we allow this new role to create, edit, delete collections and read lists?

gotson avatar Sep 25 '21 01:09 gotson

Yes, for me is this okay. See no problem with that

D1skanime avatar Sep 26 '21 18:09 D1skanime

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Dec 26 '21 01:12 github-actions[bot]

I'd like to throw my 2 cents in support of allowing permissions against the maintenance and addition of Read lists.

My use case is that I have a small server with some friends and while I can add the series they request, they possess the knowledge to make informed read lists. Read list permissions would also allow users to potentially make lists for their personal reading for easier consumption of many series.

hasjo avatar Jan 31 '22 21:01 hasjo

Hi,

This feature is planned for 1.0 release ? Sorry for the question i don't know if this function require a lot of work

kingvall avatar Jun 08 '23 19:06 kingvall