Renée

Results 465 comments of Renée

the main nanohtml module is written as a template tag so it expects an array in the first parameter. For raw HTML, the `raw()` function is a more appropriate option:...

(I will confirm the `inspect` and `format` versions later, may need to compare source a bit)

right, we assume the bundler makes the node.js globals available. This may also happen for the `Buffer` global (don't recall if we use it). the solution would be to explicitly...

For the env check, that would be enough, but we also use `process.nextTick` in the callbackify implementation

> That the file already has a typeof process check does seem to suggest that this change is reasonable, though. The other `typeof process` check is kind of vestigial, it...

> we have seen that a lot of times node.js packages fail because of (..) dependencies on native code and such, That makes a bit more sense. But this package...

The new `inspect()` function is significantly bigger which is unfortunate. Hopefully common-shakeify can usually remove it from browser builds.

Think I'll split this up so we can get promisify out the door first :P not that many people really need the new format features, probably!

promisify/callbackify was landed separately, debuglog is in another PR. Maybe we can extract the `inspect` progress from this as a separate PR too, but it may be tricky to reconcile...

IMO we should not crash on IE11, but output differences in util.inspect/util.format('%o') are okay. those are unlikely to be end-user-facing and developers who are targeting IE11- will be able to...