Renée
Renée
I'll push here the test Andrew made in https://github.com/apollographql/router/pull/6143, which validates that integer values fit in the `Int` 32 bit range.
I added a small fix as well to get that test to pass & to fix the `ID` type name issue. The implementation looks good but I think this needs...
I'd like to see tests exercising more wrong combinations of types, instead of just one for each type. I think I'm mostly looking for test assurance that we are not...
I found several minor issues by adding tests: - We accept `1234.5678` floating point values for `ID` types, which the spec arguably ambiguously allows as a return value, but explicitly...
Backing out my `ID` change to keep this PR focused on adding error messages only. I'll file a separate PR with low-/non-breaking fixes we can make to align with the...
I agree, though that discussion is maybe too big in scope for this issue 😅 I'd like to clarify what the appropriate behaviour is for GQL as it is today,...
Hmm. I think the definition of the Fragment Spread Is Possible validation itself is well-defined and unambiguous and it says that interfaces with no implementations are always an error. However...
Actually, can we not just do this once unconditionally at the start of the function? It doesn't look *that* hot...
I would close it. The wrapping closure will be inlined by the compiler, so there is no performance impact, and I think it does benefit the readability a bit. I'm...
#137 implemented an on-screen "loading gamedata" hint.