Renée

Results 478 comments of Renée

i don't know what your code looks like :) are you specifying a color now? it's hard to tell if the errors are even caused by react-vimeo, but if they...

…I haven't replied because I don't know :) I never tried using it in an extension. Maybe this package doesn't work in extension scripts for some reason. If you/someone wants...

I assumed you were developing a browser extension because the stack trace has a `chrome-extension://` url in it. `runtime.lastError` is also something to do with browser extensions.

Oh…does the embed work correctly?

OK, if there are no observable issues, it should be safe. I think you would get the same with a non-react vimeo embed.

There are also N-API functions for ToNumber() and ToBoolean(), which we currently do not implement. Perhaps this should be part of https://github.com/neon-bindings/neon/issues/569 :)

@Figments Not on this specifically—in time, the current class macro will probably be deprecated in favour of some other solution. At first, a lower-level primitive [JsBox](https://github.com/neon-bindings/rfcs/pull/33) to safely pass Rust...

That kind of automated conversion is not trivial in a compiled language like Rust. For example, AFAIK it is ~impossible~ quite hard to write an [`.export_function`](https://docs.rs/neon/0.4.0/neon/context/struct.ModuleContext.html#method.export_function) method that can accept...

we could use something like the [move-file](https://www.npmjs.com/package/move-file) module instead of fs.rename, it should avoid the cross-device issue.

The SIGINT thing is correct—you can also run clinic using the `timeout` command-line tool to automatically stop after a certain time: ```bash # start.sh timeout --signal=SIGINT 20s clinic doctor --...