Maxwell G

Results 215 comments of Maxwell G

> `trust_env=True` sounds like something we could enable. @gotmax23 what do you think? Yeah, I think it makes sense to have that as the default. > Edit: we could also...

Also, please see the [CI guidelines](https://docs.ansible.com/ansible/latest/community/collection_contributors/collection_requirements.html#ci-testing) in the collection requirements. The CI configuration should be updated to test for the latest ansible-core release that's included in Ansible 10, 2.17.

Please see [the latest sanity test report](https://github.com/ansible-community/package-test-results/blob/main/rendered/11.0.0/cyberark.pas.md) for this collection. Please see the errors in the report and address them. If these issues aren't addressed within a reasonable time period,...

I worked on https://github.com/ansible/ansible-documentation/compare/devel...gotmax23:ansible-documentation:zizmor a few months ago but never had the chance to test it and push it over the finish line.

Some of the changes suggested by zizmor are redundant because we already have a minimal set of default permissions configured in the repo settings. .github/workflows/reusable-deploy-docs.yaml does allow shell template injection...

I rebooted my previous work and submitted it as https://github.com/ansible/ansible-documentation/pull/3188. I'm now realizing that work on this had started in https://github.com/ansible/ansible-documentation/pull/3141, but I wasn't tagged there. I apologize if I...

> This is failing on Python 3.12: https://github.com/ansible-collections/community.docker/actions/runs/7513305230/job/20454910945?pr=754 That is because the package is missing an explicit dependency on setuptools, but it looks like that was fixed on main.

Yeah, I would probably avoid touching the EOL porting guides (I consider them historical documents) but don't feel super strongly.

> The sparql plugin uses NotImplemented in boolean contexts, i.e. it relies on that it evaluates as True for comparison (and sorting). This was deprecated in Python 3.9 and fails...

Do you want suggestions on the existing text or just a review of the code?