server icon indicating copy to clipboard operation
server copied to clipboard

Delete All Button confirmation

Open okuzlu opened this issue 2 years ago • 5 comments

Describe the solution you'd like I clicked by mistake on the button "Delete all" where I wanted to hit the refresh Button. A confirmation or undo feature would be helpful before all messages are deleted.

okuzlu avatar Mar 08 '22 12:03 okuzlu

I'm open to accept PRs for this.

jmattheis avatar Mar 08 '22 14:03 jmattheis

So we want a modal dialogue sort of thing that warns the user before deleting the things right?

ritikBhandari avatar May 10 '22 16:05 ritikBhandari

@ritikBhandari Yes, it should be similar to the "delete confirmation dialog" for applications. image

The confirm dialog can be used https://github.com/gotify/server/blob/master/ui/src/common/ConfirmDialog.tsx

Adding this feature will break the e2e tests, in there the dialog has to be confirmed. see f.ex https://github.com/gotify/server/blob/master/ui/src/tests/message.test.ts#L221

jmattheis avatar May 10 '22 16:05 jmattheis

Can I take up this issue?

ritikBhandari avatar May 10 '22 16:05 ritikBhandari

@ritikBhandari yes

jmattheis avatar May 10 '22 16:05 jmattheis