android icon indicating copy to clipboard operation
android copied to clipboard

Feature request: UI improvements

Open alekna opened this issue 3 years ago • 8 comments

Hi,

I know that Gotify is pretty opinionated but I'll try my luck. I'm looking to switch from Pushover to Gotify as I prefer in-house hosted solutions for reliability and predictability. I thought Gotify will be a nice replacement for Pushover until I noticed certain UI differences that are show stoppers for me.

  1. Would it be possible to display absolute time as its shown in Pushover? Displaying relative time makes absolutely no sense to me because you can't tell easily when exactly event happened.

  2. I prefer seeing as many messages in a list without having to scroll. Pushover has implemented it quite nicely. Gotify message list seems to be quite bloated for me. It fits nearly 60% less of a messages compared to Pushover.

image

alekna avatar Nov 25 '20 23:11 alekna

Hi @alekna,

cool that you've tried out Gotify (:.

  1. It is already possible to see the exact timestamp by pressing the on the time (see also https://github.com/gotify/android/issues/90). I think this is also usage depended / opinionated, some users prefer relative and some absolute time. As of this nature, this probably won't change. Also, this isn't a frequently discussed topic, so either users don't care or are okay with the current format.

  2. Originally, Gotify had a similar format that was changed in https://github.com/gotify/android/pull/56 to support longer titles. The extra space is especially needed for smaller devices, as they normally display image, title, date & delete button in the same I'd be ok with reducing the image size, but that probably won't change much.

jmattheis avatar Nov 26 '20 09:11 jmattheis

Hi @jmattheis, thanks for your reply.

  1. It would be nice if default #90 behavior was configurable in Settings. Can't imagine sane user whose preference is absolute time clicking on each notification. Sad to hear this won't change. If this software wasn't so much opinionated probably community would discuss topics like this more actively.

  2. Now exactly sure how #56 improved support for longer titles as in Pushover I can fit more information before title gets wrapped and it doesn't come at an expense of message list size.

image

alekna avatar Nov 26 '20 21:11 alekna

Hey again,

  1. I understand the reasoning and would be ok with adding such a setting.
  2. Well because it should be possible to differentiate the title from the message, we made it bold and a little bigger. To still allow bigger titles the title was moved above the Message/Image. But yeah, I understand your argument.

jmattheis avatar Nov 29 '20 14:11 jmattheis

About the layout of the messages, what about having a setting to choose the size ? It could be as follow:

  • Small: Display image as an inline icon with the title
  • Medium: Same as the Pushover example
  • Large: Same as it is now

RemiRigal avatar Feb 15 '21 09:02 RemiRigal

@RemiRigal sounds good to me. Are you willing to implement it?

alekna avatar Mar 18 '21 20:03 alekna

I will probably have some time to do this in April. I would like to have @jmattheis approval or opinion first though, I don't want to spend time on something that won't be merged.

RemiRigal avatar Mar 19 '21 08:03 RemiRigal

Sure, I'd be okay with different message layout settings. But I like to keep it simple, so how about two settings like "normal" and "compact"?

jmattheis avatar Mar 19 '21 19:03 jmattheis

@RemiRigal how's your progress with this feature?

alekna avatar May 14 '21 18:05 alekna

@alekna @jmattheis I played around and implemented a compact message layout. What do you think?

"Normal": Before

"Compact": Before

And I think especially for the compact layout we don't really need the trash can as you can simply swipe the message to the left to delete it, right?

cyb3rko avatar Oct 08 '22 22:10 cyb3rko

Looks great! I'm not sure if we should omit the trash icon, as it allows you to delete messages much faster than by swiping, but this could be changed later if that's a problem for some users.

jmattheis avatar Oct 09 '22 08:10 jmattheis

Okay, I'm going to prepare a pull request for this (and bring the trash icon to the compact layout as well).

cyb3rko avatar Oct 09 '22 08:10 cyb3rko

Compact message layout added in #246. As both points @alekna mentioned are implemented, it's finally time to close this, right?

cyb3rko avatar Oct 10 '22 19:10 cyb3rko

Correct, @cyb3rko. Thank you! :)

alekna avatar Oct 11 '22 12:10 alekna

Glad I could contribute. I just found this repo and decided to implement this here, as it has been staling for 2 years now 😬

cyb3rko avatar Oct 11 '22 13:10 cyb3rko