react-mobx-realworld-example-app icon indicating copy to clipboard operation
react-mobx-realworld-example-app copied to clipboard

No error handling

Open anjmao opened this issue 6 years ago • 1 comments

Hi,

Thanks for you work. I looked at the code and noticed that there is no proper error handling. Store methods are re-throwing in case of an error and nobody is handling that.

Example https://github.com/gothinkster/react-mobx-realworld-example-app/blob/master/src/stores/authStore.js#L42 In this case any Unsuccessful HTTP will cause Uncaught promise error.

anjmao avatar Jan 03 '19 06:01 anjmao

I don't see how this can be called a real-world example app without proper error handling, to be honest. MobX error handling patterns/practices is exactly what I'm looking for.

jcorkhill avatar Apr 14 '20 16:04 jcorkhill